[PATCH 2/2] video: delete unneeded call to platform_get_drvdata

Subsystems: framebuffer layer, the rest

STALE4473d

2 messages, 2 authors, 2014-05-19 · open the first message on its own page

[PATCH 2/2] video: delete unneeded call to platform_get_drvdata

From: Julia Lawall <hidden>
Date: 2014-05-17 06:34:22

From: Julia Lawall <redacted>

Platform_get_drvdata is an accessor function, and has no purpose if its
result is not used.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
identifier x;
type T;
@@
- T x = platform_get_drvdata(...);
... when != x
// </smpl>

Signed-off-by: Julia Lawall <redacted>

---
 drivers/video/fbdev/bf54x-lq043fb.c |    2 --
 1 file changed, 2 deletions(-)
diff --git a/drivers/video/fbdev/bf54x-lq043fb.c b/drivers/video/fbdev/bf54x-lq043fb.c
index e2c42ad..adbef54 100644
--- a/drivers/video/fbdev/bf54x-lq043fb.c
+++ b/drivers/video/fbdev/bf54x-lq043fb.c
@@ -717,8 +717,6 @@ static int bfin_bf54x_remove(struct platform_device *pdev)
 #ifdef CONFIG_PM
 static int bfin_bf54x_suspend(struct platform_device *pdev, pm_message_t state)
 {
-	struct fb_info *fbinfo = platform_get_drvdata(pdev);
-
 	bfin_write_EPPI0_CONTROL(bfin_read_EPPI0_CONTROL() & ~EPPI_EN);
 	disable_dma(CH_EPPI0);
 	bfin_write_EPPI0_STATUS(0xFFFF);

Re: [PATCH 2/2] video: delete unneeded call to platform_get_drvdata

From: Tomi Valkeinen <hidden>
Date: 2014-05-19 13:05:05

On 17/05/14 09:32, Julia Lawall wrote:
From: Julia Lawall <redacted>

Platform_get_drvdata is an accessor function, and has no purpose if its
result is not used.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/)

// <smpl>
@@
identifier x;
type T;
@@
- T x = platform_get_drvdata(...);
... when != x
// </smpl>

Signed-off-by: Julia Lawall <redacted>

---
 drivers/video/fbdev/bf54x-lq043fb.c |    2 --
 1 file changed, 2 deletions(-)
Thanks, queued for 3.16.

 Tomi

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help