# \[PATCH V2\] video : remove redundant error check

- Subsystems: FRAMEBUFFER LAYER, INTEL 810/815 FRAMEBUFFER DRIVER, THE REST
- Maintainers: Helge Deller, Antonino Daplas, Linus Torvalds
- List: linux-fbdev
- 3 messages, 2 authors
- Page: https://ratatoskr.run/linux-fbdev/2014/05/4254419/t

## \[PATCH V2\] video : remove redundant error check

- From: Daeseok Youn \<hidden\>
- Date: 2014-05-16 09:32:03 
- Message: https://ratatoskr.run/linux-fbdev/2014/05/4254419.md

```text
It doesn't need to check "err" for printing info.
And also use pr_info instead of printk.

Signed-off-by: Daeseok Youn <redacted>
---
V2: removes unneeded lines for sending a patch

 drivers/video/fbdev/i810/i810_main.c |    7 +++----
 1 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/drivers/video/fbdev/i810/i810_main.c b/drivers/video/fbdev/i810/i810_main.c
index bb674e4..15cb397 100644
--- a/drivers/video/fbdev/i810/i810_main.c
+++ b/drivers/video/fbdev/i810/i810_main.c
@@ -1910,13 +1910,12 @@ static void i810fb_find_init_mode(struct fb_info *info)
 
 	for (i = 0; i < par->ddc_num + 1; i++) {
 		err = i810_probe_i2c_connector(info, &par->edid, i);
-		if (!err)
+		if (!err) {
+			pr_info("i810fb_init_pci: DDC probe successful\n");
 			break;
+		}
 	}
 
-	if (!err)
-		printk("i810fb_init_pci: DDC probe successful\n");
-
 	fb_edid_to_monspecs(par->edid, specs);
 
 	if (specs->modedb = NULL)
-- 
1.7.1

```

## Re: \[PATCH V2\] video : remove redundant error check

- From: Tomi Valkeinen \<hidden\>
- Date: 2014-08-26 10:34:18 
- Message: https://ratatoskr.run/linux-fbdev/2014/08/4321072.md

```text
On 16/05/14 12:31, Daeseok Youn wrote:
> It doesn't need to check "err" for printing info.
> And also use pr_info instead of printk.
> 
> Signed-off-by: Daeseok Youn <redacted>
> ---
> V2: removes unneeded lines for sending a patch
> 
>  drivers/video/fbdev/i810/i810_main.c |    7 +++----
>  1 files changed, 3 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/video/fbdev/i810/i810_main.c b/drivers/video/fbdev/i810/i810_main.c
> index bb674e4..15cb397 100644
> --- a/drivers/video/fbdev/i810/i810_main.c
> +++ b/drivers/video/fbdev/i810/i810_main.c
> @@ -1910,13 +1910,12 @@ static void i810fb_find_init_mode(struct fb_info *info)
>  
>  	for (i = 0; i < par->ddc_num + 1; i++) {
>  		err = i810_probe_i2c_connector(info, &par->edid, i);
> -		if (!err)
> +		if (!err) {
> +			pr_info("i810fb_init_pci: DDC probe successful\n");
>  			break;
> +		}
>  	}
>  
> -	if (!err)
> -		printk("i810fb_init_pci: DDC probe successful\n");
> -
>  	fb_edid_to_monspecs(par->edid, specs);
>  
>  	if (specs->modedb == NULL)
> 

I don't know... I think I personally like more the original version. In
fact, the whole print looks quite useless to me, or at least it should
be a debug print.

 Tomi


```

## Re: \[PATCH V2\] video : remove redundant error check

- From: DaeSeok Youn \<hidden\>
- Date: 2014-08-27 10:01:01 
- Message: https://ratatoskr.run/linux-fbdev/2014/08/4321817.md

```text
Hi,

2014-08-26 19:34 GMT+09:00 Tomi Valkeinen [ref]:
> On 16/05/14 12:31, Daeseok Youn wrote:
>> It doesn't need to check "err" for printing info.
>> And also use pr_info instead of printk.
>>
>> Signed-off-by: Daeseok Youn <redacted>
>> ---
>> V2: removes unneeded lines for sending a patch
>>
>>  drivers/video/fbdev/i810/i810_main.c |    7 +++----
>>  1 files changed, 3 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/video/fbdev/i810/i810_main.c b/drivers/video/fbdev/i810/i810_main.c
>> index bb674e4..15cb397 100644
>> --- a/drivers/video/fbdev/i810/i810_main.c
>> +++ b/drivers/video/fbdev/i810/i810_main.c
>> @@ -1910,13 +1910,12 @@ static void i810fb_find_init_mode(struct fb_info *info)
>>
>>       for (i = 0; i < par->ddc_num + 1; i++) {
>>               err = i810_probe_i2c_connector(info, &par->edid, i);
>> -             if (!err)
>> +             if (!err) {
>> +                     pr_info("i810fb_init_pci: DDC probe successful\n");
>>                       break;
>> +             }
>>       }
>>
>> -     if (!err)
>> -             printk("i810fb_init_pci: DDC probe successful\n");
>> -
>>       fb_edid_to_monspecs(par->edid, specs);
>>
>>       if (specs->modedb = NULL)
>>
>
> I don't know... I think I personally like more the original version. In
> fact, the whole print looks quite useless to me, or at least it should
> be a debug print.
Yes. this patch doesn't need.

Thanks for review.

regards,
Daeseok Youn.
>
>  Tomi
>
>
```
