[PATCH] video: bf54x-lq043fb: fix build error

From: Steven Miao <redacted>

should include linux/gpio.h

Signed-off-by: Steven Miao <redacted>
---
 drivers/video/bf54x-lq043fb.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/video/bf54x-lq043fb.c b/drivers/video/bf54x-lq043fb.c
index 42b8f9d..d2b54f1 100644
--- a/drivers/video/bf54x-lq043fb.c
+++ b/drivers/video/bf54x-lq043fb.c

@@ -49,6 +49,7 @@
 #include <linux/spinlock.h>
 #include <linux/dma-mapping.h>
 #include <linux/platform_device.h>
+#include <linux/gpio.h>
 
 #include <asm/blackfin.h>
 #include <asm/irq.h>

-- 
1.7.9.5

On 12/04/14 04:30, Steven Miao wrote:

The driver includes <asm/gpio.h>. I think that should be removed, and
<linux/gpio.h> should be used.

Can you also remove the asm/gpio.h in your patch, and see if it compiles
fine?

 Tomi

Hi Tomi,

On Mon, Apr 14, 2014 at 8:44 PM, Tomi Valkeinen [off-list ref] wrote:

On 12/04/14 04:30, Steven Miao wrote:

quoted

From: Steven Miao <redacted>

should include linux/gpio.h

Signed-off-by: Steven Miao <redacted>
---
 drivers/video/bf54x-lq043fb.c |    1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/video/bf54x-lq043fb.c b/drivers/video/bf54x-lq043fb.c
index 42b8f9d..d2b54f1 100644
--- a/drivers/video/bf54x-lq043fb.c
+++ b/drivers/video/bf54x-lq043fb.c

@@ -49,6 +49,7 @@
 #include <linux/spinlock.h>
 #include <linux/dma-mapping.h>
 #include <linux/platform_device.h>
+#include <linux/gpio.h>

The driver includes <asm/gpio.h>. I think that should be removed, and
<linux/gpio.h> should be used.

Yes, it should be removed.

Can you also remove the asm/gpio.h in your patch, and see if it compiles
fine?

I have tested it, it's fine. I'll resend the patch.

 Tomi

-steven