# \[PATCH\] video: fbdev: uvesafb: Remove redundant NULL check in uvesafb\_remove - Subsystems: FRAMEBUFFER LAYER, UVESAFB DRIVER, THE REST - Maintainers: Helge Deller, Michal Januszewski, Linus Torvalds - List: linux-fbdev - 2 messages, 2 authors - Page: https://ratatoskr.run/linux-fbdev/2014/03/4211975/t ## \[PATCH\] video: fbdev: uvesafb: Remove redundant NULL check in uvesafb\_remove - From: Wang YanQing \ - Date: 2014-03-05 15:55:25 - Message: https://ratatoskr.run/linux-fbdev/2014/03/4211975.md ```text Because uvesafb_par is allocated as part of fb_info in uvesafb_probe, so we don't need to do NULL check for both fb_info and uvesafb_par in uvesafb_remove. [ This patch also fix a warning report by fengguang.wu@intel.com "drivers/video/fbdev/uvesafb.c:1815 uvesafb_remove() warn: variable dereferenced before check 'par'" ] Signed-off-by: Wang YanQing --- drivers/video/fbdev/uvesafb.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/video/fbdev/uvesafb.c b/drivers/video/fbdev/uvesafb.c index 1f38445..18352b2 100644 --- a/drivers/video/fbdev/uvesafb.c +++ b/drivers/video/fbdev/uvesafb.c @@ -1812,11 +1812,9 @@ static int uvesafb_remove(struct platform_device *dev) fb_destroy_modedb(info->monspecs.modedb); fb_dealloc_cmap(&info->cmap); - if (par) { - kfree(par->vbe_modes); - kfree(par->vbe_state_orig); - kfree(par->vbe_state_saved); - } + kfree(par->vbe_modes); + kfree(par->vbe_state_orig); + kfree(par->vbe_state_saved); framebuffer_release(info); } -- 1.8.3.4.8.g69490f3.dirty ``` ## Re: \[PATCH\] video: fbdev: uvesafb: Remove redundant NULL check in uvesafb\_remove - From: Tomi Valkeinen \ - Date: 2014-03-06 09:32:11 - Message: https://ratatoskr.run/linux-fbdev/2014/03/4212521.md ```text On 05/03/14 17:54, Wang YanQing wrote: > Because uvesafb_par is allocated as part of fb_info in uvesafb_probe, > so we don't need to do NULL check for both fb_info and uvesafb_par in > uvesafb_remove. > > [ This patch also fix a warning report by fengguang.wu@intel.com > "drivers/video/fbdev/uvesafb.c:1815 uvesafb_remove() > warn: variable dereferenced before check 'par'" ] > > Signed-off-by: Wang YanQing > --- > drivers/video/fbdev/uvesafb.c | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/drivers/video/fbdev/uvesafb.c b/drivers/video/fbdev/uvesafb.c > index 1f38445..18352b2 100644 > --- a/drivers/video/fbdev/uvesafb.c > +++ b/drivers/video/fbdev/uvesafb.c > @@ -1812,11 +1812,9 @@ static int uvesafb_remove(struct platform_device *dev) > fb_destroy_modedb(info->monspecs.modedb); > fb_dealloc_cmap(&info->cmap); > > - if (par) { > - kfree(par->vbe_modes); > - kfree(par->vbe_state_orig); > - kfree(par->vbe_state_saved); > - } > + kfree(par->vbe_modes); > + kfree(par->vbe_state_orig); > + kfree(par->vbe_state_saved); > > framebuffer_release(info); > } > Thanks, queuing for 3.15. Tomi ```