[PATCH] hyperv_fb: Add screen refresh after pause/resume operation

Subsystems: framebuffer layer, the rest

STALE4576d REVIEWED: 1 (1M)

1 review trailer.

3 messages, 1 author, 2014-02-14 · open the first message on its own page

[PATCH] hyperv_fb: Add screen refresh after pause/resume operation

From: Haiyang Zhang <haiyangz@microsoft.com>
Date: 2014-01-13 23:31:48

This is necessary because after VM is pause/resumed, some portion of
the screen may need refresh.

Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>
---
 drivers/video/hyperv_fb.c |   10 +++++++++-
 1 files changed, 9 insertions(+), 1 deletions(-)
diff --git a/drivers/video/hyperv_fb.c b/drivers/video/hyperv_fb.c
index 130708f..bbcc8c0 100644
--- a/drivers/video/hyperv_fb.c
+++ b/drivers/video/hyperv_fb.c
@@ -218,6 +218,7 @@ struct hvfb_par {
 
 	struct delayed_work dwork;
 	bool update;
+	bool xrefresh;
 
 	u32 pseudo_palette[16];
 	u8 init_buf[MAX_VMBUS_PKT_SIZE];
@@ -369,7 +370,7 @@ static void synthvid_recv_sub(struct hv_device *hdev)
 			synthvid_send_situ(hdev);
 		}
 
-		par->update = msg->feature_chg.is_dirt_needed;
+		par->xrefresh = par->update = msg->feature_chg.is_dirt_needed;
 		if (par->update)
 			schedule_delayed_work(&par->dwork, HVFB_UPDATE_DELAY);
 	}
@@ -522,6 +523,13 @@ static void hvfb_update_work(struct work_struct *w)
 {
 	struct hvfb_par *par = container_of(w, struct hvfb_par, dwork.work);
 	struct fb_info *info = par->info;
+	char *argv[] = {"/usr/bin/xrefresh", "-display", ":0.0", NULL};
+	char *envp[] = {"HOME=/", "PATH=/sbin:/usr/sbin:/bin:/usr/bin", NULL };
+
+	if (par->xrefresh) {
+		par->xrefresh = false;
+		call_usermodehelper(argv[0], argv, envp, UMH_NO_WAIT);
+	}
 
 	if (par->fb_ready)
 		synthvid_update(info);
-- 
1.7.4.1

RE: [PATCH] hyperv_fb: Add screen refresh after pause/resume operation

From: Haiyang Zhang <haiyangz@microsoft.com>
Date: 2014-02-10 20:24:14

-----Original Message-----
From: Haiyang Zhang [mailto:haiyangz@microsoft.com]
Sent: Monday, January 13, 2014 7:21 PM
To: FlorianSchandinat@gmx.de; akpm@linux-foundation.org; linux-
fbdev@vger.kernel.org
Cc: Haiyang Zhang; KY Srinivasan; olaf@aepfle.de; jasowang@redhat.com;
linux-kernel@vger.kernel.org; driverdev-devel@linuxdriverproject.org
Subject: [PATCH] hyperv_fb: Add screen refresh after pause/resume operation

This is necessary because after VM is pause/resumed, some portion of the
screen may need refresh.

Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>
---
This was submitted before the tree re-opened. Is it still being considered?

Thanks,
- Haiyang

RE: [PATCH] hyperv_fb: Add screen refresh after pause/resume operation

From: Haiyang Zhang <haiyangz@microsoft.com>
Date: 2014-02-14 21:59:08

-----Original Message-----
From: Haiyang Zhang [mailto:haiyangz@microsoft.com]
Sent: Monday, January 13, 2014 7:21 PM
To: FlorianSchandinat@gmx.de; akpm@linux-foundation.org; linux-
fbdev@vger.kernel.org
Cc: Haiyang Zhang; KY Srinivasan; olaf@aepfle.de; jasowang@redhat.com;
linux-kernel@vger.kernel.org; driverdev-devel@linuxdriverproject.org
Subject: [PATCH] hyperv_fb: Add screen refresh after pause/resume
operation

This is necessary because after VM is pause/resumed, some portion of the
screen may need refresh.

Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Reviewed-by: K. Y. Srinivasan <kys@microsoft.com>
---
Hi Tomi and Andrew,

This patch has been submitted for a while. Do I need to re-submit it, or make
any changes?

Thanks,
- Haiyang
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help