[PATCH 9/9] video: amba-clcd: Remove unnecessary amba_set_drvdata()

Subsystems: framebuffer layer, the rest

STALE4659d

2 messages, 2 authors, 2013-10-09 · open the first message on its own page

[PATCH 9/9] video: amba-clcd: Remove unnecessary amba_set_drvdata()

From: Michal Simek <hidden>
Date: 2013-10-03 09:47:35

Driver core clears the driver data to NULL after device_release
or on probe failure, so just remove it from here.

Driver core change:
"device-core: Ensure drvdata = NULL when no driver is bound"
(sha1: 0998d0631001288a5974afc0b2a5f568bcdecb4d)

Signed-off-by: Michal Simek <redacted>
---
 drivers/video/amba-clcd.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/drivers/video/amba-clcd.c b/drivers/video/amba-clcd.c
index 0a2cce7..0bab6ab 100644
--- a/drivers/video/amba-clcd.c
+++ b/drivers/video/amba-clcd.c
@@ -594,8 +594,6 @@ static int clcdfb_remove(struct amba_device *dev)
 {
 	struct clcd_fb *fb = amba_get_drvdata(dev);

-	amba_set_drvdata(dev, NULL);
-
 	clcdfb_disable(fb);
 	unregister_framebuffer(&fb->fb);
 	if (fb->fb.cmap.len)
--
1.8.2.3

Re: [PATCH 9/9] video: amba-clcd: Remove unnecessary amba_set_drvdata()

From: Tomi Valkeinen <hidden>
Date: 2013-10-09 08:44:49

On 03/10/13 12:46, Michal Simek wrote:
quoted hunk
Driver core clears the driver data to NULL after device_release
or on probe failure, so just remove it from here.

Driver core change:
"device-core: Ensure drvdata = NULL when no driver is bound"
(sha1: 0998d0631001288a5974afc0b2a5f568bcdecb4d)

Signed-off-by: Michal Simek <redacted>
---
 drivers/video/amba-clcd.c | 2 --
 1 file changed, 2 deletions(-)
diff --git a/drivers/video/amba-clcd.c b/drivers/video/amba-clcd.c
index 0a2cce7..0bab6ab 100644
--- a/drivers/video/amba-clcd.c
+++ b/drivers/video/amba-clcd.c
@@ -594,8 +594,6 @@ static int clcdfb_remove(struct amba_device *dev)
 {
 	struct clcd_fb *fb = amba_get_drvdata(dev);

-	amba_set_drvdata(dev, NULL);
-
 	clcdfb_disable(fb);
 	unregister_framebuffer(&fb->fb);
 	if (fb->fb.cmap.len)
--
1.8.2.3
Thanks, queued for 3.13.

 Tomi


Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help