[PATCH 1/2] hyperv-fb: add pci stub

Subsystems: framebuffer layer, the rest

STALE4680d

10 messages, 4 authors, 2013-10-09 · open the first message on its own page

[PATCH 1/2] hyperv-fb: add pci stub

From: Gerd Hoffmann <kraxel@redhat.com>
Date: 2013-10-02 11:59:26

This patch adds a pci stub driver to hyper-fb.  The hyperv framebuffer
driver will bind to the pci device then, so linux kernel and userspace
know there is a proper kernel driver for the device active.  lspci shows
this for example:

[root@dhcp231 ~]# lspci -vs8
00:08.0 VGA compatible controller: Microsoft Corporation Hyper-V virtual
VGA (prog-if 00 [VGA controller])
        Flags: bus master, fast devsel, latency 0, IRQ 11
        Memory at f8000000 (32-bit, non-prefetchable) [sizedM]
        Expansion ROM at <unassigned> [disabled]
        Kernel driver in use: hyperv_fb

Another effect is that the xorg vesa driver will not attach to the
device and thus the Xorg server will automatically use the fbdev
driver instead.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 drivers/video/hyperv_fb.c | 40 +++++++++++++++++++++++++++++++++++++++-
 1 file changed, 39 insertions(+), 1 deletion(-)

diff --git a/drivers/video/hyperv_fb.c b/drivers/video/hyperv_fb.c
index 8ac99b8..8d456dc 100644
--- a/drivers/video/hyperv_fb.c
+++ b/drivers/video/hyperv_fb.c

@@ -795,12 +795,21 @@ static int hvfb_remove(struct hv_device *hdev)
 }
 
 
+static DEFINE_PCI_DEVICE_TABLE(pci_stub_id_table) = {
+	{
+		.vendor      = PCI_VENDOR_ID_MICROSOFT,
+		.device      = PCI_DEVICE_ID_HYPERV_VIDEO,
+	},
+	{ /* end of list */ }
+};
+
 static const struct hv_vmbus_device_id id_table[] = {
 	/* Synthetic Video Device GUID */
 	{HV_SYNTHVID_GUID},
 	{}
 };
 
+MODULE_DEVICE_TABLE(pci, pci_stub_id_table);
 MODULE_DEVICE_TABLE(vmbus, id_table);
 
 static struct hv_driver hvfb_drv = {

@@ -810,14 +819,43 @@ static struct hv_driver hvfb_drv = {
 	.remove = hvfb_remove,
 };
 
+static int hvfb_pci_stub_probe(struct pci_dev *pdev,
+			       const struct pci_device_id *ent)
+{
+	return 0;
+}
+
+static void hvfb_pci_stub_remove(struct pci_dev *pdev)
+{
+}
+
+static struct pci_driver hvfb_pci_stub_driver = {
+	.name =		KBUILD_MODNAME,
+	.id_table =	pci_stub_id_table,
+	.probe =	hvfb_pci_stub_probe,
+	.remove =	hvfb_pci_stub_remove,
+};
 
 static int __init hvfb_drv_init(void)
 {
-	return vmbus_driver_register(&hvfb_drv);
+	int ret;
+
+	ret = vmbus_driver_register(&hvfb_drv);
+	if (ret != 0)
+		return ret;
+
+	ret = pci_register_driver(&hvfb_pci_stub_driver);
+	if (ret != 0) {
+		vmbus_driver_unregister(&hvfb_drv);
+		return ret;
+	}
+
+	return 0;
 }
 
 static void __exit hvfb_drv_exit(void)
 {
+	pci_unregister_driver(&hvfb_pci_stub_driver);
 	vmbus_driver_unregister(&hvfb_drv);
 }

-- 
1.8.3.1

[PATCH 2/2] hyperv-fb: add blanking support

From: Gerd Hoffmann <kraxel@redhat.com>
Date: 2013-10-02 11:56:03

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 drivers/video/hyperv_fb.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/video/hyperv_fb.c b/drivers/video/hyperv_fb.c
index 8d456dc..130708f 100644
--- a/drivers/video/hyperv_fb.c
+++ b/drivers/video/hyperv_fb.c

@@ -575,6 +575,10 @@ static int hvfb_setcolreg(unsigned regno, unsigned red, unsigned green,
 	return 0;
 }
 
+static int hvfb_blank(int blank, struct fb_info *info)
+{
+	return 1;	/* get fb_blank to set the colormap to all black */
+}
 
 static struct fb_ops hvfb_ops = {
 	.owner = THIS_MODULE,

@@ -584,6 +588,7 @@ static struct fb_ops hvfb_ops = {
 	.fb_fillrect = cfb_fillrect,
 	.fb_copyarea = cfb_copyarea,
 	.fb_imageblit = cfb_imageblit,
+	.fb_blank = hvfb_blank,
 };

-- 
1.8.3.1

RE: [PATCH 2/2] hyperv-fb: add blanking support

From: Haiyang Zhang <haiyangz@microsoft.com>
Date: 2013-10-02 20:59:48

-----Original Message-----
From: linux-fbdev-owner@vger.kernel.org [mailto:linux-fbdev-
owner@vger.kernel.org] On Behalf Of Gerd Hoffmann
Sent: Wednesday, October 2, 2013 7:55 AM
Cc: Gerd Hoffmann; KY Srinivasan; Haiyang Zhang; Jean-Christophe Plagniol-
Villard; Tomi Valkeinen; open list:Hyper-V CORE AND...; open
list:FRAMEBUFFER LAYER; open list
Subject: [PATCH 2/2] hyperv-fb: add blanking support

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

Acked-by: Haiyang Zhang <haiyangz@microsoft.com>

RE: [PATCH 1/2] hyperv-fb: add pci stub

From: KY Srinivasan <kys@microsoft.com>
Date: 2013-10-02 14:29:34

quoted hunk

-----Original Message-----
From: Gerd Hoffmann [mailto:kraxel@redhat.com]
Sent: Wednesday, October 02, 2013 4:55 AM
Cc: Gerd Hoffmann; KY Srinivasan; Haiyang Zhang; Jean-Christophe Plagniol-
Villard; Tomi Valkeinen; open list:Hyper-V CORE AND...; open list:FRAMEBUFFER
LAYER; open list
Subject: [PATCH 1/2] hyperv-fb: add pci stub

This patch adds a pci stub driver to hyper-fb.  The hyperv framebuffer
driver will bind to the pci device then, so linux kernel and userspace
know there is a proper kernel driver for the device active.  lspci shows
this for example:

[root@dhcp231 ~]# lspci -vs8
00:08.0 VGA compatible controller: Microsoft Corporation Hyper-V virtual
VGA (prog-if 00 [VGA controller])
        Flags: bus master, fast devsel, latency 0, IRQ 11
        Memory at f8000000 (32-bit, non-prefetchable) [sizedM]
        Expansion ROM at <unassigned> [disabled]
        Kernel driver in use: hyperv_fb

Another effect is that the xorg vesa driver will not attach to the
device and thus the Xorg server will automatically use the fbdev
driver instead.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 drivers/video/hyperv_fb.c | 40
+++++++++++++++++++++++++++++++++++++++-
 1 file changed, 39 insertions(+), 1 deletion(-)

diff --git a/drivers/video/hyperv_fb.c b/drivers/video/hyperv_fb.c
index 8ac99b8..8d456dc 100644
--- a/drivers/video/hyperv_fb.c
+++ b/drivers/video/hyperv_fb.c

@@ -795,12 +795,21 @@ static int hvfb_remove(struct hv_device *hdev)
 }


+static DEFINE_PCI_DEVICE_TABLE(pci_stub_id_table) = {
+	{
+		.vendor      = PCI_VENDOR_ID_MICROSOFT,
+		.device      = PCI_DEVICE_ID_HYPERV_VIDEO,
+	},
+	{ /* end of list */ }
+};
+
 static const struct hv_vmbus_device_id id_table[] = {
 	/* Synthetic Video Device GUID */
 	{HV_SYNTHVID_GUID},
 	{}
 };

+MODULE_DEVICE_TABLE(pci, pci_stub_id_table);
 MODULE_DEVICE_TABLE(vmbus, id_table);

 static struct hv_driver hvfb_drv = {

@@ -810,14 +819,43 @@ static struct hv_driver hvfb_drv = {
 	.remove = hvfb_remove,
 };

+static int hvfb_pci_stub_probe(struct pci_dev *pdev,
+			       const struct pci_device_id *ent)
+{
+	return 0;
+}
+
+static void hvfb_pci_stub_remove(struct pci_dev *pdev)
+{
+}
+
+static struct pci_driver hvfb_pci_stub_driver = {
+	.name =		KBUILD_MODNAME,
+	.id_table =	pci_stub_id_table,
+	.probe =	hvfb_pci_stub_probe,
+	.remove =	hvfb_pci_stub_remove,
+};

 static int __init hvfb_drv_init(void)
 {
-	return vmbus_driver_register(&hvfb_drv);
+	int ret;
+
+	ret = vmbus_driver_register(&hvfb_drv);
+	if (ret != 0)
+		return ret;
+
+	ret = pci_register_driver(&hvfb_pci_stub_driver);
+	if (ret != 0) {
+		vmbus_driver_unregister(&hvfb_drv);
+		return ret;
+	}
+
+	return 0;
 }

 static void __exit hvfb_drv_exit(void)
 {
+	pci_unregister_driver(&hvfb_pci_stub_driver);
 	vmbus_driver_unregister(&hvfb_drv);
 }

--

1.8.3.1

Gerd,

Thanks for doing this. This certainly will address some of the issues that are reported. I do have a question though - how would this work if we don't have PCI bus in the guest.

Regards,

K. Y

Re: [PATCH 1/2] hyperv-fb: add pci stub

From: Gerd Hoffmann <kraxel@redhat.com>
Date: 2013-10-07 06:50:47

On Mi, 2013-10-02 at 14:29 +0000, KY Srinivasan wrote:

quoted

This patch adds a pci stub driver to hyper-fb.  The hyperv framebuffer
driver will bind to the pci device then, so linux kernel and userspace
know there is a proper kernel driver for the device active.  lspci shows
this for example:

Gerd,

Thanks for doing this. This certainly will address some of the issues that are reported. I do have a question though - how would this work if we don't have PCI bus in the guest.

The hyperv framebuffer driver wouldn't work in the first place then as
it looks up the framebuffer address in pci config space (see hvfb_getmem
function).

cheers,
  Gerd

RE: [PATCH 1/2] hyperv-fb: add pci stub

From: KY Srinivasan <kys@microsoft.com>
Date: 2013-10-07 17:13:14

DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogR2VyZCBIb2ZmbWFubiBb
bWFpbHRvOmtyYXhlbEByZWRoYXQuY29tXQ0KPiBTZW50OiBTdW5kYXksIE9jdG9iZXIgMDYsIDIw
MTMgMTE6NTEgUE0NCj4gVG86IEtZIFNyaW5pdmFzYW4NCj4gQ2M6IEhhaXlhbmcgWmhhbmc7IEpl
YW4tQ2hyaXN0b3BoZSBQbGFnbmlvbC1WaWxsYXJkOyBUb21pIFZhbGtlaW5lbjsgb3Blbg0KPiBs
aXN0Okh5cGVyLVYgQ09SRSBBTkQuLi47IG9wZW4gbGlzdDpGUkFNRUJVRkZFUiBMQVlFUjsgb3Bl
biBsaXN0DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggMS8yXSBoeXBlcnYtZmI6IGFkZCBwY2kgc3R1
Yg0KPiANCj4gT24gTWksIDIwMTMtMTAtMDIgYXQgMTQ6MjkgKzAwMDAsIEtZIFNyaW5pdmFzYW4g
d3JvdGU6DQo+ID4NCj4gPiA+IFRoaXMgcGF0Y2ggYWRkcyBhIHBjaSBzdHViIGRyaXZlciB0byBo
eXBlci1mYi4gIFRoZSBoeXBlcnYgZnJhbWVidWZmZXINCj4gPiA+IGRyaXZlciB3aWxsIGJpbmQg
dG8gdGhlIHBjaSBkZXZpY2UgdGhlbiwgc28gbGludXgga2VybmVsIGFuZCB1c2Vyc3BhY2UNCj4g
PiA+IGtub3cgdGhlcmUgaXMgYSBwcm9wZXIga2VybmVsIGRyaXZlciBmb3IgdGhlIGRldmljZSBh
Y3RpdmUuICBsc3BjaSBzaG93cw0KPiA+ID4gdGhpcyBmb3IgZXhhbXBsZToNCj4gDQo+ID4gR2Vy
ZCwNCj4gPg0KPiA+IFRoYW5rcyBmb3IgZG9pbmcgdGhpcy4gVGhpcyBjZXJ0YWlubHkgd2lsbCBh
ZGRyZXNzIHNvbWUgb2YgdGhlIGlzc3VlcyB0aGF0IGFyZQ0KPiByZXBvcnRlZC4gSSBkbyBoYXZl
IGEgcXVlc3Rpb24gdGhvdWdoIC0gaG93IHdvdWxkIHRoaXMgd29yayBpZiB3ZSBkb24ndCBoYXZl
IFBDSQ0KPiBidXMgaW4gdGhlIGd1ZXN0Lg0KPiANCj4gVGhlIGh5cGVydiBmcmFtZWJ1ZmZlciBk
cml2ZXIgd291bGRuJ3Qgd29yayBpbiB0aGUgZmlyc3QgcGxhY2UgdGhlbiBhcw0KPiBpdCBsb29r
cyB1cCB0aGUgZnJhbWVidWZmZXIgYWRkcmVzcyBpbiBwY2kgY29uZmlnIHNwYWNlIChzZWUgaHZm
Yl9nZXRtZW0NCj4gZnVuY3Rpb24pLg0KDQpXZSBhcmUgZ29pbmcgdG8gZml4IHRoaXMgYXMgd2Ug
bW92ZSB0aGlzIGNvZGUgdG8gcnVuIG9uIG91ciBVRUZJIGZpcm13YXJlLiANCg0KUmVnYXJkcywN
Cg0KSy4gWQ0KDQo

Re: [PATCH 1/2] hyperv-fb: add pci stub

From: Gerd Hoffmann <kraxel@redhat.com>
Date: 2013-10-08 08:44:48

On Mo, 2013-10-07 at 17:12 +0000, KY Srinivasan wrote:

quoted

-----Original Message-----
From: Gerd Hoffmann [mailto:kraxel@redhat.com]
Sent: Sunday, October 06, 2013 11:51 PM
To: KY Srinivasan
Cc: Haiyang Zhang; Jean-Christophe Plagniol-Villard; Tomi Valkeinen; open
list:Hyper-V CORE AND...; open list:FRAMEBUFFER LAYER; open list
Subject: Re: [PATCH 1/2] hyperv-fb: add pci stub

On Mi, 2013-10-02 at 14:29 +0000, KY Srinivasan wrote:

quoted

This patch adds a pci stub driver to hyper-fb.  The hyperv framebuffer
driver will bind to the pci device then, so linux kernel and userspace
know there is a proper kernel driver for the device active.  lspci shows
this for example:

quoted

Gerd,

Thanks for doing this. This certainly will address some of the issues that are

reported. I do have a question though - how would this work if we don't have PCI
bus in the guest.

The hyperv framebuffer driver wouldn't work in the first place then as
it looks up the framebuffer address in pci config space (see hvfb_getmem
function).

We are going to fix this as we move this code to run on our UEFI firmware.

Hmm, windows server 2012 seems to have no option to enable uefi.  So I
guess this is still in development?  How this is going to look like?

Probably you are going for pure uefi firmware, without csm, to be able
to leave all the legacy bios stuff behind in uefi mode.  Therefore no
vesa bios support.  efi drivers for vmbus network/storage/display/input
in the firmware.  No legacy ide/vga pci devices.  Correct?

The linux kernel will come up with efifb then, switching over to
hyperv-fb once the driver is loaded.  The hyperv-fb pci stub driver will
not bind to the hyperv vga pci device if it isn't present in the guest.
hyperv-fb will load just fine nevertheless (once hvfb_getmem is fixed to
not depend on the pci device config space).  The pci stub added by the
patch and the vmbus driver in hyperv-fb are completely independent.

cheers,
  Gerd

RE: [PATCH 1/2] hyperv-fb: add pci stub

From: KY Srinivasan <kys@microsoft.com>
Date: 2013-10-08 14:48:35

DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogR2VyZCBIb2ZmbWFubiBb
bWFpbHRvOmtyYXhlbEByZWRoYXQuY29tXQ0KPiBTZW50OiBUdWVzZGF5LCBPY3RvYmVyIDA4LCAy
MDEzIDE6NDEgQU0NCj4gVG86IEtZIFNyaW5pdmFzYW4NCj4gQ2M6IEhhaXlhbmcgWmhhbmc7IEpl
YW4tQ2hyaXN0b3BoZSBQbGFnbmlvbC1WaWxsYXJkOyBUb21pIFZhbGtlaW5lbjsgb3Blbg0KPiBs
aXN0Okh5cGVyLVYgQ09SRSBBTkQuLi47IG9wZW4gbGlzdDpGUkFNRUJVRkZFUiBMQVlFUjsgb3Bl
biBsaXN0DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0ggMS8yXSBoeXBlcnYtZmI6IGFkZCBwY2kgc3R1
Yg0KPiANCj4gT24gTW8sIDIwMTMtMTAtMDcgYXQgMTc6MTIgKzAwMDAsIEtZIFNyaW5pdmFzYW4g
d3JvdGU6DQo+ID4NCj4gPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4gPiBGcm9t
OiBHZXJkIEhvZmZtYW5uIFttYWlsdG86a3JheGVsQHJlZGhhdC5jb21dDQo+ID4gPiBTZW50OiBT
dW5kYXksIE9jdG9iZXIgMDYsIDIwMTMgMTE6NTEgUE0NCj4gPiA+IFRvOiBLWSBTcmluaXZhc2Fu
DQo+ID4gPiBDYzogSGFpeWFuZyBaaGFuZzsgSmVhbi1DaHJpc3RvcGhlIFBsYWduaW9sLVZpbGxh
cmQ7IFRvbWkgVmFsa2VpbmVuOyBvcGVuDQo+ID4gPiBsaXN0Okh5cGVyLVYgQ09SRSBBTkQuLi47
IG9wZW4gbGlzdDpGUkFNRUJVRkZFUiBMQVlFUjsgb3BlbiBsaXN0DQo+ID4gPiBTdWJqZWN0OiBS
ZTogW1BBVENIIDEvMl0gaHlwZXJ2LWZiOiBhZGQgcGNpIHN0dWINCj4gPiA+DQo+ID4gPiBPbiBN
aSwgMjAxMy0xMC0wMiBhdCAxNDoyOSArMDAwMCwgS1kgU3Jpbml2YXNhbiB3cm90ZToNCj4gPiA+
ID4NCj4gPiA+ID4gPiBUaGlzIHBhdGNoIGFkZHMgYSBwY2kgc3R1YiBkcml2ZXIgdG8gaHlwZXIt
ZmIuICBUaGUgaHlwZXJ2IGZyYW1lYnVmZmVyDQo+ID4gPiA+ID4gZHJpdmVyIHdpbGwgYmluZCB0
byB0aGUgcGNpIGRldmljZSB0aGVuLCBzbyBsaW51eCBrZXJuZWwgYW5kIHVzZXJzcGFjZQ0KPiA+
ID4gPiA+IGtub3cgdGhlcmUgaXMgYSBwcm9wZXIga2VybmVsIGRyaXZlciBmb3IgdGhlIGRldmlj
ZSBhY3RpdmUuICBsc3BjaSBzaG93cw0KPiA+ID4gPiA+IHRoaXMgZm9yIGV4YW1wbGU6DQo+ID4g
Pg0KPiA+ID4gPiBHZXJkLA0KPiA+ID4gPg0KPiA+ID4gPiBUaGFua3MgZm9yIGRvaW5nIHRoaXMu
IFRoaXMgY2VydGFpbmx5IHdpbGwgYWRkcmVzcyBzb21lIG9mIHRoZSBpc3N1ZXMgdGhhdCBhcmUN
Cj4gPiA+IHJlcG9ydGVkLiBJIGRvIGhhdmUgYSBxdWVzdGlvbiB0aG91Z2ggLSBob3cgd291bGQg
dGhpcyB3b3JrIGlmIHdlIGRvbid0IGhhdmUNCj4gUENJDQo+ID4gPiBidXMgaW4gdGhlIGd1ZXN0
Lg0KPiA+ID4NCj4gPiA+IFRoZSBoeXBlcnYgZnJhbWVidWZmZXIgZHJpdmVyIHdvdWxkbid0IHdv
cmsgaW4gdGhlIGZpcnN0IHBsYWNlIHRoZW4gYXMNCj4gPiA+IGl0IGxvb2tzIHVwIHRoZSBmcmFt
ZWJ1ZmZlciBhZGRyZXNzIGluIHBjaSBjb25maWcgc3BhY2UgKHNlZSBodmZiX2dldG1lbQ0KPiA+
ID4gZnVuY3Rpb24pLg0KPiA+DQo+ID4gV2UgYXJlIGdvaW5nIHRvIGZpeCB0aGlzIGFzIHdlIG1v
dmUgdGhpcyBjb2RlIHRvIHJ1biBvbiBvdXIgVUVGSSBmaXJtd2FyZS4NCj4gDQo+IEhtbSwgd2lu
ZG93cyBzZXJ2ZXIgMjAxMiBzZWVtcyB0byBoYXZlIG5vIG9wdGlvbiB0byBlbmFibGUgdWVmaS4g
IFNvIEkNCj4gZ3Vlc3MgdGhpcyBpcyBzdGlsbCBpbiBkZXZlbG9wbWVudD8gIEhvdyB0aGlzIGlz
IGdvaW5nIHRvIGxvb2sgbGlrZT8NCg0KVGhpcyBmZWF0dXJlIGlzIHRoZXJlIGluIFdTMjAxMiBS
Mg0KPiANCj4gUHJvYmFibHkgeW91IGFyZSBnb2luZyBmb3IgcHVyZSB1ZWZpIGZpcm13YXJlLCB3
aXRob3V0IGNzbSwgdG8gYmUgYWJsZQ0KPiB0byBsZWF2ZSBhbGwgdGhlIGxlZ2FjeSBiaW9zIHN0
dWZmIGJlaGluZCBpbiB1ZWZpIG1vZGUuICBUaGVyZWZvcmUgbm8NCj4gdmVzYSBiaW9zIHN1cHBv
cnQuICBlZmkgZHJpdmVycyBmb3Igdm1idXMgbmV0d29yay9zdG9yYWdlL2Rpc3BsYXkvaW5wdXQN
Cj4gaW4gdGhlIGZpcm13YXJlLiAgTm8gbGVnYWN5IGlkZS92Z2EgcGNpIGRldmljZXMuICBDb3Jy
ZWN0Pw0KPiANClNvbWV0aGluZyBvbiB0aGVzZSBsaW5lcy4NCg0KPiBUaGUgbGludXgga2VybmVs
IHdpbGwgY29tZSB1cCB3aXRoIGVmaWZiIHRoZW4sIHN3aXRjaGluZyBvdmVyIHRvDQo+IGh5cGVy
di1mYiBvbmNlIHRoZSBkcml2ZXIgaXMgbG9hZGVkLiAgVGhlIGh5cGVydi1mYiBwY2kgc3R1YiBk
cml2ZXIgd2lsbA0KPiBub3QgYmluZCB0byB0aGUgaHlwZXJ2IHZnYSBwY2kgZGV2aWNlIGlmIGl0
IGlzbid0IHByZXNlbnQgaW4gdGhlIGd1ZXN0Lg0KPiBoeXBlcnYtZmIgd2lsbCBsb2FkIGp1c3Qg
ZmluZSBuZXZlcnRoZWxlc3MgKG9uY2UgaHZmYl9nZXRtZW0gaXMgZml4ZWQgdG8NCj4gbm90IGRl
cGVuZCBvbiB0aGUgcGNpIGRldmljZSBjb25maWcgc3BhY2UpLiAgVGhlIHBjaSBzdHViIGFkZGVk
IGJ5IHRoZQ0KPiBwYXRjaCBhbmQgdGhlIHZtYnVzIGRyaXZlciBpbiBoeXBlcnYtZmIgYXJlIGNv
bXBsZXRlbHkgaW5kZXBlbmRlbnQuDQoNCk9rOyB0aGFua3MuDQoNCksuIFkNCiANCg0K

RE: [PATCH 1/2] hyperv-fb: add pci stub

From: Haiyang Zhang <haiyangz@microsoft.com>
Date: 2013-10-02 20:59:26

-----Original Message-----
From: linux-fbdev-owner@vger.kernel.org [mailto:linux-fbdev-
owner@vger.kernel.org] On Behalf Of Gerd Hoffmann
Sent: Wednesday, October 2, 2013 7:55 AM
Cc: Gerd Hoffmann; KY Srinivasan; Haiyang Zhang; Jean-Christophe Plagniol-
Villard; Tomi Valkeinen; open list:Hyper-V CORE AND...; open
list:FRAMEBUFFER LAYER; open list
Subject: [PATCH 1/2] hyperv-fb: add pci stub

This patch adds a pci stub driver to hyper-fb.  The hyperv framebuffer driver
will bind to the pci device then, so linux kernel and userspace know there is a
proper kernel driver for the device active.  lspci shows this for example:

[root@dhcp231 ~]# lspci -vs8
00:08.0 VGA compatible controller: Microsoft Corporation Hyper-V virtual
VGA (prog-if 00 [VGA controller])
        Flags: bus master, fast devsel, latency 0, IRQ 11
        Memory at f8000000 (32-bit, non-prefetchable) [sizedM]
        Expansion ROM at <unassigned> [disabled]
        Kernel driver in use: hyperv_fb

Another effect is that the xorg vesa driver will not attach to the device and
thus the Xorg server will automatically use the fbdev driver instead.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>

Acked-by: Haiyang Zhang <haiyangz@microsoft.com>

Thank you for fixing this!

- Haiyang

Re: [PATCH 1/2] hyperv-fb: add pci stub

From: Tomi Valkeinen <hidden>
Date: 2013-10-09 09:53:32

On 02/10/13 14:55, Gerd Hoffmann wrote:

This patch adds a pci stub driver to hyper-fb.  The hyperv framebuffer
driver will bind to the pci device then, so linux kernel and userspace
know there is a proper kernel driver for the device active.  lspci shows
this for example:

[root@dhcp231 ~]# lspci -vs8
00:08.0 VGA compatible controller: Microsoft Corporation Hyper-V virtual
VGA (prog-if 00 [VGA controller])
        Flags: bus master, fast devsel, latency 0, IRQ 11
        Memory at f8000000 (32-bit, non-prefetchable) [size=64M]
        Expansion ROM at <unassigned> [disabled]
        Kernel driver in use: hyperv_fb

Another effect is that the xorg vesa driver will not attach to the
device and thus the Xorg server will automatically use the fbdev
driver instead.

Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
 drivers/video/hyperv_fb.c | 40 +++++++++++++++++++++++++++++++++++++++-
 1 file changed, 39 insertions(+), 1 deletion(-)

Thanks, queuing the series for 3.13.

 Tomi

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help