# RE: \[PATCH v2 10/24\] video: da8xx-fb: fb\_set\_par support

- From: Etheridge, Darren \<hidden\>
- Date: 2013-08-01 11:12:36 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2013/08/13465180
- Thread: https://ratatoskr.run/linux-fbdev/2013/07/13465102/t.md

```text
>>> +static int da8xxfb_set_par(struct fb_info *info) {
>>> +   struct da8xx_fb_par *par = info->par;
>>> +   int ret;
>>> +   bool raster = da8xx_fb_is_raster_enabled();
>>> +
>>> +   if (raster)
>>> +           lcd_disable_raster(true);
>>> +   else
>>> +           lcd_disable_raster(false);
>>
>> This looks odd. If raster is enabled, you disable it. And if raster is disabled,
>> you disable it.
>
> I corrected this one in patch 0011 - I agree this code is very confusing.
>
>In patch 11 you add the enum. I wasn't referring to that. My point was
>that even if raster is already disabled,
>lcd_disable_raster(dont-wait-for-framedone) is called.

Oh I see, yes you are absolutely right - I will check into what the intent of this code was and see if it is even necessary.


```