# \[PATCH\] backlight: lp855x: set zero brightness at FBBLANK - Subsystems: FRAMEBUFFER LAYER, BACKLIGHT CLASS/SUBSYSTEM, THE REST - Maintainers: Helge Deller, Lee Jones, Daniel Thompson, Jingoo Han, Linus Torvalds - List: linux-fbdev - 4 messages, 4 authors - Page: https://ratatoskr.run/linux-fbdev/2013/07/4076709/t ## \[PATCH\] backlight: lp855x: set zero brightness at FBBLANK - From: Oskar Andero \ - Date: 2013-07-02 12:16:00 - Message: https://ratatoskr.run/linux-fbdev/2013/07/4076709.md ```text From: Shingo Nakao When backlight turns on early from display, a white line can be seen on the screen. Therefore make sure backlight is off when we are under an fb blank event. Signed-off-by: Shingo Nakao Cc: Milo Kim Cc: Richard Purdie Signed-off-by: Oskar Andero --- drivers/video/backlight/lp855x_bl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c index a0e1e02..c0b41f1 100644 --- a/drivers/video/backlight/lp855x_bl.c +++ b/drivers/video/backlight/lp855x_bl.c @@ -246,7 +246,7 @@ static int lp855x_bl_update_status(struct backlight_device *bl) { struct lp855x *lp = bl_get_data(bl); - if (bl->props.state & BL_CORE_SUSPENDED) + if (bl->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK)) bl->props.brightness = 0; if (lp->mode = PWM_BASED) { -- 1.8.1.5 ``` ## Re: \[PATCH\] backlight: lp855x: set zero brightness at FBBLANK - From: Kim, Milo \ - Date: 2013-07-02 23:25:03 - Message: https://ratatoskr.run/linux-fbdev/2013/07/4076999.md ```text > From: Shingo Nakao > > When backlight turns on early from display, a white line can be > seen on the screen. Therefore make sure backlight is off when we > are under an fb blank event. > > Signed-off-by: Shingo Nakao > Cc: Milo Kim > Cc: Richard Purdie > Signed-off-by: Oskar Andero Acked-by: Milo Kim > --- > drivers/video/backlight/lp855x_bl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c > index a0e1e02..c0b41f1 100644 > --- a/drivers/video/backlight/lp855x_bl.c > +++ b/drivers/video/backlight/lp855x_bl.c > @@ -246,7 +246,7 @@ static int lp855x_bl_update_status(struct backlight_device *bl) > { > struct lp855x *lp = bl_get_data(bl); > > - if (bl->props.state & BL_CORE_SUSPENDED) > + if (bl->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK)) > bl->props.brightness = 0; > > if (lp->mode = PWM_BASED) { > -- > 1.8.1.5 ``` ## Re: \[PATCH\] backlight: lp855x: set zero brightness at FBBLANK - From: Jingoo Han \ - Date: 2013-07-03 01:52:21 - Message: https://ratatoskr.run/linux-fbdev/2013/07/4077040.md ```text On Tuesday, July 02, 2013 9:16 PM, Oskar Andero wrote: > > From: Shingo Nakao > > When backlight turns on early from display, a white line can be > seen on the screen. Therefore make sure backlight is off when we > are under an fb blank event. > > Signed-off-by: Shingo Nakao > Cc: Milo Kim > Cc: Richard Purdie > Signed-off-by: Oskar Andero Acked-by: Jingoo Han Best regards, Jingoo Han > --- > drivers/video/backlight/lp855x_bl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c > index a0e1e02..c0b41f1 100644 > --- a/drivers/video/backlight/lp855x_bl.c > +++ b/drivers/video/backlight/lp855x_bl.c > @@ -246,7 +246,7 @@ static int lp855x_bl_update_status(struct backlight_device *bl) > { > struct lp855x *lp = bl_get_data(bl); > > - if (bl->props.state & BL_CORE_SUSPENDED) > + if (bl->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK)) > bl->props.brightness = 0; > > if (lp->mode = PWM_BASED) { > -- > 1.8.1.5 > ``` ## Re: \[PATCH\] backlight: lp855x: set zero brightness at FBBLANK - From: Tomi Valkeinen \ - Date: 2013-07-26 08:46:00 - Message: https://ratatoskr.run/linux-fbdev/2013/07/4089465.md ```text On 02/07/13 15:15, Oskar Andero wrote: > From: Shingo Nakao > > When backlight turns on early from display, a white line can be > seen on the screen. Therefore make sure backlight is off when we > are under an fb blank event. > > Signed-off-by: Shingo Nakao > Cc: Milo Kim > Cc: Richard Purdie > Signed-off-by: Oskar Andero > --- > drivers/video/backlight/lp855x_bl.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/backlight/lp855x_bl.c b/drivers/video/backlight/lp855x_bl.c > index a0e1e02..c0b41f1 100644 > --- a/drivers/video/backlight/lp855x_bl.c > +++ b/drivers/video/backlight/lp855x_bl.c > @@ -246,7 +246,7 @@ static int lp855x_bl_update_status(struct backlight_device *bl) > { > struct lp855x *lp = bl_get_data(bl); > > - if (bl->props.state & BL_CORE_SUSPENDED) > + if (bl->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK)) > bl->props.brightness = 0; > > if (lp->mode == PWM_BASED) { > Thanks, I've applied this into my 3.12/fbdev branch. Tomi ```