# \[PATCH V2 2/3\] ARM: dts: Add DP PHY node to exynos5250.dtsi

- Subsystems: THE REST
- Maintainers: Linus Torvalds
- List: linux-fbdev
- 2 messages, 2 authors
- Page: https://ratatoskr.run/linux-fbdev/2013/06/8074030/t

## \[PATCH V2 2/3\] ARM: dts: Add DP PHY node to exynos5250.dtsi

- From: Jingoo Han \<hidden\>
- Date: 2013-06-28 07:16:44 
- Message: https://ratatoskr.run/linux-fbdev/2013/06/8074030.md

```text
Add PHY provider node for the DP PHY.

Signed-off-by: Jingoo Han <redacted>
---
 arch/arm/boot/dts/exynos5250.dtsi |   13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 41cd625..f7bac75 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -614,6 +614,12 @@
 		interrupts = <0 94 0>;
 	};
 
+	dp_phy: video-phy@10040720 {
+		compatible = "samsung,exynos5250-dp-video-phy";
+		reg = <0x10040720 4>;
+		#phy-cells = <0>;
+	};
+
 	dp-controller {
 		compatible = "samsung,exynos5-dp";
 		reg = <0x145b0000 0x1000>;
@@ -623,11 +629,8 @@
 		clock-names = "dp";
 		#address-cells = <1>;
 		#size-cells = <0>;
-
-		dptx-phy {
-			reg = <0x10040720>;
-			samsung,enable-mask = <1>;
-		};
+		phys = <&dp_phy 0>;
+		phy-names = "dp";
 	};
 
 	fimd {
-- 
1.7.10.4


```

## Re: \[PATCH V2 2/3\] ARM: dts: Add DP PHY node to exynos5250.dtsi

- From: Felipe Balbi \<hidden\>
- Date: 2013-06-28 09:34:06 
- Message: https://ratatoskr.run/linux-fbdev/2013/06/8074042.md

```text
On Fri, Jun 28, 2013 at 04:16:44PM +0900, Jingoo Han wrote:
> Add PHY provider node for the DP PHY.
> 
> Signed-off-by: Jingoo Han <redacted>
> ---
>  arch/arm/boot/dts/exynos5250.dtsi |   13 ++++++++-----
>  1 file changed, 8 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
> index 41cd625..f7bac75 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -614,6 +614,12 @@
>  		interrupts = <0 94 0>;
>  	};
>  
> +	dp_phy: video-phy@10040720 {
> +		compatible = "samsung,exynos5250-dp-video-phy";
> +		reg = <0x10040720 4>;
> +		#phy-cells = <0>;
> +	};
> +
>  	dp-controller {
>  		compatible = "samsung,exynos5-dp";
>  		reg = <0x145b0000 0x1000>;
> @@ -623,11 +629,8 @@
>  		clock-names = "dp";
>  		#address-cells = <1>;
>  		#size-cells = <0>;
> -
> -		dptx-phy {
> -			reg = <0x10040720>;
> -			samsung,enable-mask = <1>;
> -		};
> +		phys = <&dp_phy 0>;

phy-cells being 0, means that this would become:

		phys = <&dp_phy>;

> +		phy-names = "dp";

for the label, I would use something more descriptive such as
'display-port'.

other than that:

Acked-by: Felipe Balbi <redacted>

-- 
balbi
```