# \[PATCH v2 4/4\] at91/avr32/atmel\_lcdfb: prepare clk before calling enable - Subsystems: FRAMEBUFFER LAYER, THE REST - Maintainers: Helge Deller, Linus Torvalds - Status: SUPERSEDED (Superseded by v4 posted 2013-07-18) - Superseded by v4 (posted 2013-07-18). - Revision v2 (3 revisions archived). - List: linux-fbdev - 3 messages, 3 authors - Page: https://ratatoskr.run/linux-fbdev/2013/06/4072402/t ## \[PATCH v2 4/4\] at91/avr32/atmel\_lcdfb: prepare clk before calling enable - From: Boris BREZILLON \ - Date: 2013-06-25 08:20:48 - Message: https://ratatoskr.run/linux-fbdev/2013/06/4072402.md ```text Replace clk_enable/disable with clk_prepare_enable/disable_unprepare to avoid common clk framework warnings. Signed-off-by: Boris BREZILLON --- drivers/video/atmel_lcdfb.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c index 540909d..8525457 100644 --- a/drivers/video/atmel_lcdfb.c +++ b/drivers/video/atmel_lcdfb.c @@ -893,14 +893,14 @@ static int __init atmel_lcdfb_init_fbinfo(struct atmel_lcdfb_info *sinfo) static void atmel_lcdfb_start_clock(struct atmel_lcdfb_info *sinfo) { - clk_enable(sinfo->bus_clk); - clk_enable(sinfo->lcdc_clk); + clk_prepare_enable(sinfo->bus_clk); + clk_prepare_enable(sinfo->lcdc_clk); } static void atmel_lcdfb_stop_clock(struct atmel_lcdfb_info *sinfo) { - clk_disable(sinfo->bus_clk); - clk_disable(sinfo->lcdc_clk); + clk_disable_unprepare(sinfo->bus_clk); + clk_disable_unprepare(sinfo->lcdc_clk); } -- 1.7.9.5 ``` ## Re: \[PATCH v2 4/4\] at91/avr32/atmel\_lcdfb: prepare clk before calling enable - From: Nicolas Ferre \ - Date: 2013-06-25 08:16:11 - Message: https://ratatoskr.run/linux-fbdev/2013/06/4072396.md ```text On 25/06/2013 10:14, Boris BREZILLON : > Replace clk_enable/disable with clk_prepare_enable/disable_unprepare to > avoid common clk framework warnings. > > Signed-off-by: Boris BREZILLON Acked-by: Nicolas Ferre Jean-Christophe, can you take this one? Thanks, best regards, > --- > drivers/video/atmel_lcdfb.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c > index 540909d..8525457 100644 > --- a/drivers/video/atmel_lcdfb.c > +++ b/drivers/video/atmel_lcdfb.c > @@ -893,14 +893,14 @@ static int __init atmel_lcdfb_init_fbinfo(struct atmel_lcdfb_info *sinfo) > > static void atmel_lcdfb_start_clock(struct atmel_lcdfb_info *sinfo) > { > - clk_enable(sinfo->bus_clk); > - clk_enable(sinfo->lcdc_clk); > + clk_prepare_enable(sinfo->bus_clk); > + clk_prepare_enable(sinfo->lcdc_clk); > } > > static void atmel_lcdfb_stop_clock(struct atmel_lcdfb_info *sinfo) > { > - clk_disable(sinfo->bus_clk); > - clk_disable(sinfo->lcdc_clk); > + clk_disable_unprepare(sinfo->bus_clk); > + clk_disable_unprepare(sinfo->lcdc_clk); > } > > > -- Nicolas Ferre ``` ## Re: \[PATCH v2 4/4\] at91/avr32/atmel\_lcdfb: prepare clk before calling enable - From: Jean-Christophe PLAGNIOL-VILLARD \ - Date: 2013-07-03 11:51:08 - Message: https://ratatoskr.run/linux-fbdev/2013/07/4077201.md ```text On 10:16 Tue 25 Jun , Nicolas Ferre wrote: > On 25/06/2013 10:14, Boris BREZILLON : > >Replace clk_enable/disable with clk_prepare_enable/disable_unprepare to > >avoid common clk framework warnings. > > > >Signed-off-by: Boris BREZILLON > > Acked-by: Nicolas Ferre > > Jean-Christophe, can you take this one? Yes I'll Best Regards, J. > > Thanks, best regards, > > >--- > > drivers/video/atmel_lcdfb.c | 8 ++++---- > > 1 file changed, 4 insertions(+), 4 deletions(-) > > > >diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c > >index 540909d..8525457 100644 > >--- a/drivers/video/atmel_lcdfb.c > >+++ b/drivers/video/atmel_lcdfb.c > >@@ -893,14 +893,14 @@ static int __init atmel_lcdfb_init_fbinfo(struct atmel_lcdfb_info *sinfo) > > > > static void atmel_lcdfb_start_clock(struct atmel_lcdfb_info *sinfo) > > { > >- clk_enable(sinfo->bus_clk); > >- clk_enable(sinfo->lcdc_clk); > >+ clk_prepare_enable(sinfo->bus_clk); > >+ clk_prepare_enable(sinfo->lcdc_clk); > > } > > > > static void atmel_lcdfb_stop_clock(struct atmel_lcdfb_info *sinfo) > > { > >- clk_disable(sinfo->bus_clk); > >- clk_disable(sinfo->lcdc_clk); > >+ clk_disable_unprepare(sinfo->bus_clk); > >+ clk_disable_unprepare(sinfo->lcdc_clk); > > } > > > > > > > > > -- > Nicolas Ferre ```