# \[PATCH v3\] simplefb: add support for a8b8g8r8 pixel format

- Subsystems: FRAMEBUFFER LAYER, OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS, THE REST
- Maintainers: Helge Deller, Rob Herring, Krzysztof Kozlowski, Conor Dooley, Linus Torvalds
- Status: REVIEWED · 1 review, 0 by maintainers (Olof Johansson)
- Reviewed.
- 1 review trailer.
- List: linux-fbdev
- 4 messages, 4 authors
- Page: https://ratatoskr.run/linux-fbdev/2013/06/4062352/t

## \[PATCH v3\] simplefb: add support for a8b8g8r8 pixel format

- From: Alexandre Courbot \<acourbot@nvidia.com\>
- Date: 2013-06-07 07:31:39 
- Message: https://ratatoskr.run/linux-fbdev/2013/06/4062352.md

```text
A framebuffer of this format is set up by SHIELD's bootloader.

Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
Acked-by: Olof Johansson <redacted>
---
Changes from v2:
- Fixed typo in format (Thanks Alexander van Heukelum!)

Changes from v1:
- Added description to motivate the change
- Added ack

 Documentation/devicetree/bindings/video/simple-framebuffer.txt | 1 +
 drivers/video/simplefb.c                                       | 1 +
 2 files changed, 2 insertions(+)

diff --git a/Documentation/devicetree/bindings/video/simple-framebuffer.txt b/Documentation/devicetree/bindings/video/simple-framebuffer.txt
index 3ea4605..70c26f3 100644
--- a/Documentation/devicetree/bindings/video/simple-framebuffer.txt
+++ b/Documentation/devicetree/bindings/video/simple-framebuffer.txt
@@ -12,6 +12,7 @@ Required properties:
 - stride: The number of bytes in each line of the framebuffer.
 - format: The format of the framebuffer surface. Valid values are:
   - r5g6b5 (16-bit pixels, d[15:11]=r, d[10:5]=g, d[4:0]=b).
+  - a8b8g8r8 (32-bit pixels, d[31:24]=a, d[23:16]=b, d[15:8]=g, d[7:0]=r).
 
 Example:
 
diff --git a/drivers/video/simplefb.c b/drivers/video/simplefb.c
index e2e9e3e..f015482 100644
--- a/drivers/video/simplefb.c
+++ b/drivers/video/simplefb.c
@@ -84,6 +84,7 @@ struct simplefb_format {
 
 static struct simplefb_format simplefb_formats[] = {
 	{ "r5g6b5", 16, {11, 5}, {5, 6}, {0, 5}, {0, 0} },
+	{ "a8b8g8r8", 32, {0, 8}, {8, 8}, {16, 8}, {24, 8} },
 };
 
 struct simplefb_params {
-- 
1.8.3

```

## Re: \[PATCH v3\] simplefb: add support for a8b8g8r8 pixel format

- From: Stephen Warren \<hidden\>
- Date: 2013-06-07 16:24:10 
- Message: https://ratatoskr.run/linux-fbdev/2013/06/4062724.md

```text
On 06/07/2013 01:31 AM, Alexandre Courbot wrote:
> A framebuffer of this format is set up by SHIELD's bootloader.
> 
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> Acked-by: Olof Johansson <redacted>

Reviewed-by: Stephen Warren <redacted>
```

## Re: \[PATCH v3\] simplefb: add support for a8b8g8r8 pixel format

- From: Alexandre Courbot \<hidden\>
- Date: 2013-06-14 10:18:42 
- Message: https://ratatoskr.run/linux-fbdev/2013/06/4066136.md

```text
On Sat, Jun 8, 2013 at 1:24 AM, Stephen Warren [ref] wrote:
> On 06/07/2013 01:31 AM, Alexandre Courbot wrote:
>> A framebuffer of this format is set up by SHIELD's bootloader.
>>
>> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
>> Acked-by: Olof Johansson <redacted>
>
> Reviewed-by: Stephen Warren <redacted>

Jean-Christophe, Tomi, do you plan to merge this?

Alex.
```

## Re: \[PATCH v3\] simplefb: add support for a8b8g8r8 pixel format

- From: Tomi Valkeinen \<hidden\>
- Date: 2013-07-26 08:51:42 
- Message: https://ratatoskr.run/linux-fbdev/2013/07/4089467.md

```text
On 07/06/13 10:31, Alexandre Courbot wrote:
> A framebuffer of this format is set up by SHIELD's bootloader.
> 
> Signed-off-by: Alexandre Courbot <acourbot@nvidia.com>
> Acked-by: Olof Johansson <redacted>
> ---
> Changes from v2:
> - Fixed typo in format (Thanks Alexander van Heukelum!)
> 
> Changes from v1:
> - Added description to motivate the change
> - Added ack
> 
>  Documentation/devicetree/bindings/video/simple-framebuffer.txt | 1 +
>  drivers/video/simplefb.c                                       | 1 +
>  2 files changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/video/simple-framebuffer.txt b/Documentation/devicetree/bindings/video/simple-framebuffer.txt
> index 3ea4605..70c26f3 100644
> --- a/Documentation/devicetree/bindings/video/simple-framebuffer.txt
> +++ b/Documentation/devicetree/bindings/video/simple-framebuffer.txt
> @@ -12,6 +12,7 @@ Required properties:
>  - stride: The number of bytes in each line of the framebuffer.
>  - format: The format of the framebuffer surface. Valid values are:
>    - r5g6b5 (16-bit pixels, d[15:11]=r, d[10:5]=g, d[4:0]=b).
> +  - a8b8g8r8 (32-bit pixels, d[31:24]=a, d[23:16]=b, d[15:8]=g, d[7:0]=r).
>  
>  Example:
>  
> diff --git a/drivers/video/simplefb.c b/drivers/video/simplefb.c
> index e2e9e3e..f015482 100644
> --- a/drivers/video/simplefb.c
> +++ b/drivers/video/simplefb.c
> @@ -84,6 +84,7 @@ struct simplefb_format {
>  
>  static struct simplefb_format simplefb_formats[] = {
>  	{ "r5g6b5", 16, {11, 5}, {5, 6}, {0, 5}, {0, 0} },
> +	{ "a8b8g8r8", 32, {0, 8}, {8, 8}, {16, 8}, {24, 8} },
>  };
>  
>  struct simplefb_params {

Thanks, I've applied this into my 3.12/fbdev branch.

 Tomi


```