# \[PATCH\] video/matrox/matroxfb\_maven: Use module\_i2c\_driver to register driver - Subsystems: FRAMEBUFFER LAYER, THE REST - Maintainers: Helge Deller, Linus Torvalds - List: linux-fbdev - 3 messages, 2 authors - Page: https://ratatoskr.run/linux-fbdev/2013/05/4052316/t ## \[PATCH\] video/matrox/matroxfb\_maven: Use module\_i2c\_driver to register driver - From: Peter Huewe \ - Date: 2013-05-20 19:31:10 - Message: https://ratatoskr.run/linux-fbdev/2013/05/4052316.md ```text Removing some boilerplate by using module_i2c_driver instead of calling register and unregister in the otherwise empty init/exit functions Signed-off-by: Peter Huewe --- drivers/video/matrox/matroxfb_maven.c | 13 +------------ 1 file changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/video/matrox/matroxfb_maven.c b/drivers/video/matrox/matroxfb_maven.c index 217678e..fd4b64e 100644 --- a/drivers/video/matrox/matroxfb_maven.c +++ b/drivers/video/matrox/matroxfb_maven.c @@ -1283,19 +1283,8 @@ static struct i2c_driver maven_driver={ .id_table = maven_id, }; -static int __init matroxfb_maven_init(void) -{ - return i2c_add_driver(&maven_driver); -} - -static void __exit matroxfb_maven_exit(void) -{ - i2c_del_driver(&maven_driver); -} - +module_i2c_driver(maven_driver); MODULE_AUTHOR("(c) 1999-2002 Petr Vandrovec "); MODULE_DESCRIPTION("Matrox G200/G400 Matrox MGA-TVO driver"); MODULE_LICENSE("GPL"); -module_init(matroxfb_maven_init); -module_exit(matroxfb_maven_exit); /* we do not have __setup() yet */ -- 1.8.1.5 ``` ## Re: \[PATCH\] video/matrox/matroxfb\_maven: Use module\_i2c\_driver to register driver - From: Jean Delvare \ - Date: 2013-05-20 19:42:22 - Message: https://ratatoskr.run/linux-fbdev/2013/05/4052325.md ```text On Mon, 20 May 2013 21:36:18 +0200, Peter Huewe wrote: > Removing some boilerplate by using module_i2c_driver instead of calling > register and unregister in the otherwise empty init/exit functions > > Signed-off-by: Peter Huewe > --- > drivers/video/matrox/matroxfb_maven.c | 13 +------------ > 1 file changed, 1 insertion(+), 12 deletions(-) > > diff --git a/drivers/video/matrox/matroxfb_maven.c b/drivers/video/matrox/matroxfb_maven.c > index 217678e..fd4b64e 100644 > --- a/drivers/video/matrox/matroxfb_maven.c > +++ b/drivers/video/matrox/matroxfb_maven.c > @@ -1283,19 +1283,8 @@ static struct i2c_driver maven_driver={ > .id_table = maven_id, > }; > > -static int __init matroxfb_maven_init(void) > -{ > - return i2c_add_driver(&maven_driver); > -} > - > -static void __exit matroxfb_maven_exit(void) > -{ > - i2c_del_driver(&maven_driver); > -} > - > +module_i2c_driver(maven_driver); > MODULE_AUTHOR("(c) 1999-2002 Petr Vandrovec [ref]"); > MODULE_DESCRIPTION("Matrox G200/G400 Matrox MGA-TVO driver"); > MODULE_LICENSE("GPL"); > -module_init(matroxfb_maven_init); > -module_exit(matroxfb_maven_exit); > /* we do not have __setup() yet */ This last comment could certainly go away as well, AFAICT it's a now meaningless relic. Other than this: Reviewed-by: Jean Delvare -- Jean Delvare ``` ## \[PATCH v2\] video/matrox/matroxfb\_maven: Use module\_i2c\_driver to register driver - From: Peter Huewe \ - Date: 2013-05-20 19:56:30 - Message: https://ratatoskr.run/linux-fbdev/2013/05/4052336.md ```text Removing some boilerplate by using module_i2c_driver instead of calling register and unregister in the otherwise empty init/exit functions. Also removed a useless comment as suggested by Jean Delvare Signed-off-by: Peter Huewe Reviewed-by: Jean Delvare --- drivers/video/matrox/matroxfb_maven.c | 14 +------------- 1 file changed, 1 insertion(+), 13 deletions(-) diff --git a/drivers/video/matrox/matroxfb_maven.c b/drivers/video/matrox/matroxfb_maven.c index 217678e..6360796 100644 --- a/drivers/video/matrox/matroxfb_maven.c +++ b/drivers/video/matrox/matroxfb_maven.c @@ -1283,19 +1283,7 @@ static struct i2c_driver maven_driver={ .id_table = maven_id, }; -static int __init matroxfb_maven_init(void) -{ - return i2c_add_driver(&maven_driver); -} - -static void __exit matroxfb_maven_exit(void) -{ - i2c_del_driver(&maven_driver); -} - +module_i2c_driver(maven_driver); MODULE_AUTHOR("(c) 1999-2002 Petr Vandrovec "); MODULE_DESCRIPTION("Matrox G200/G400 Matrox MGA-TVO driver"); MODULE_LICENSE("GPL"); -module_init(matroxfb_maven_init); -module_exit(matroxfb_maven_exit); -/* we do not have __setup() yet */ -- 1.8.1.5 ```