[PATCH] drivers: video: mxsfb: clean use of devm_ioremap_resource()
DORMANTno replies
From: Laurent Navet <hidden>
Date: 2013-05-14 09:18:23
Also in:
lkml
Subsystem:
framebuffer layer, the rest · Maintainers:
Helge Deller, Linus Torvalds
Check of 'res' and calls to dev_err are already done in devm_ioremap_resource, so no need to do them twice. Signed-off-by: Laurent Navet <redacted> --- drivers/video/mxsfb.c | 14 ++++---------- 1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
index 21223d4..0f3d0fc 100644
--- a/drivers/video/mxsfb.c
+++ b/drivers/video/mxsfb.c@@ -884,9 +884,10 @@ static int mxsfb_probe(struct platform_device *pdev) pdev->id_entry = of_id->data; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) { - dev_err(&pdev->dev, "Cannot get memory IO resource\n"); - return -ENODEV; + host->base = devm_ioremap_resource(&pdev->dev, res); + if (IS_ERR(host->base)) { + ret = PTR_ERR(host->base); + goto fb_release; } fb_info = framebuffer_alloc(sizeof(struct mxsfb_info), &pdev->dev);
@@ -897,13 +898,6 @@ static int mxsfb_probe(struct platform_device *pdev) host = to_imxfb_host(fb_info); - host->base = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(host->base)) { - dev_err(&pdev->dev, "ioremap failed\n"); - ret = PTR_ERR(host->base); - goto fb_release; - } - host->pdev = pdev; platform_set_drvdata(pdev, host);
--
1.7.10.4