[PATCH v4] drivers: video: use module_platform_driver_probe()

Subsystems: framebuffer layer, the rest

STALE4946d

6 messages, 2 authors, 2013-04-04 · open the first message on its own page

[PATCH v4] drivers: video: use module_platform_driver_probe()

From: Fabio Porcedda <hidden>
Date: 2013-03-15 13:02:38

This patch converts the drivers to use the
module_platform_driver_probe() macro which makes the code smaller and
a bit simpler.

Signed-off-by: Fabio Porcedda <redacted>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Acked-by: Nicolas Ferre <redacted> # atmel_lcdfb.c
Cc: Tomi Valkeinen <redacted>
Cc: David Howells <dhowells@redhat.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> # amifb.c
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---

Notes:
    v4:
     - add acked-by Nicolas & Laurent
     - fix amifb.c
    v3:
     - add missing drivers: amifb, atmel_lcdfb, vrfb
     - split patch set to each maintainer to easy up respin
    v2:
     - rebased over linux-next and remove already converted drivers

 drivers/video/amifb.c          | 14 +-------------
 drivers/video/atmel_lcdfb.c    | 13 +------------
 drivers/video/omap2/vrfb.c     | 13 +------------
 drivers/video/sh_mipi_dsi.c    | 12 +-----------
 drivers/video/sh_mobile_hdmi.c | 12 +-----------
 5 files changed, 5 insertions(+), 59 deletions(-)
diff --git a/drivers/video/amifb.c b/drivers/video/amifb.c
index 7fa1bf8..77cb4ff 100644
--- a/drivers/video/amifb.c
+++ b/drivers/video/amifb.c
@@ -3788,19 +3788,7 @@ static struct platform_driver amifb_driver = {
 	},
 };
 
-static int __init amifb_init(void)
-{
-	return platform_driver_probe(&amifb_driver, amifb_probe);
-}
-
-module_init(amifb_init);
-
-static void __exit amifb_exit(void)
-{
-	platform_driver_unregister(&amifb_driver);
-}
-
-module_exit(amifb_exit);
+module_platform_driver_probe(amifb_driver, amifb_probe);
 
 MODULE_LICENSE("GPL");
 MODULE_ALIAS("platform:amiga-video");
diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c
index 12cf5f3..654e102 100644
--- a/drivers/video/atmel_lcdfb.c
+++ b/drivers/video/atmel_lcdfb.c
@@ -1150,18 +1150,7 @@ static struct platform_driver atmel_lcdfb_driver = {
 	},
 };
 
-static int __init atmel_lcdfb_init(void)
-{
-	return platform_driver_probe(&atmel_lcdfb_driver, atmel_lcdfb_probe);
-}
-
-static void __exit atmel_lcdfb_exit(void)
-{
-	platform_driver_unregister(&atmel_lcdfb_driver);
-}
-
-module_init(atmel_lcdfb_init);
-module_exit(atmel_lcdfb_exit);
+module_platform_driver_probe(atmel_lcdfb_driver, atmel_lcdfb_probe);
 
 MODULE_DESCRIPTION("AT91/AT32 LCD Controller framebuffer driver");
 MODULE_AUTHOR("Nicolas Ferre <nicolas.ferre@atmel.com>");
diff --git a/drivers/video/omap2/vrfb.c b/drivers/video/omap2/vrfb.c
index 10560ef..5261229 100644
--- a/drivers/video/omap2/vrfb.c
+++ b/drivers/video/omap2/vrfb.c
@@ -397,18 +397,7 @@ static struct platform_driver vrfb_driver = {
 	.remove		= __exit_p(vrfb_remove),
 };
 
-static int __init vrfb_init(void)
-{
-	return platform_driver_probe(&vrfb_driver, &vrfb_probe);
-}
-
-static void __exit vrfb_exit(void)
-{
-	platform_driver_unregister(&vrfb_driver);
-}
-
-module_init(vrfb_init);
-module_exit(vrfb_exit);
+module_platform_driver_probe(vrfb_driver, vrfb_probe);
 
 MODULE_AUTHOR("Tomi Valkeinen <tomi.valkeinen@ti.com>");
 MODULE_DESCRIPTION("OMAP VRFB");
diff --git a/drivers/video/sh_mipi_dsi.c b/drivers/video/sh_mipi_dsi.c
index 701b461..6cad530 100644
--- a/drivers/video/sh_mipi_dsi.c
+++ b/drivers/video/sh_mipi_dsi.c
@@ -581,17 +581,7 @@ static struct platform_driver sh_mipi_driver = {
 	},
 };
 
-static int __init sh_mipi_init(void)
-{
-	return platform_driver_probe(&sh_mipi_driver, sh_mipi_probe);
-}
-module_init(sh_mipi_init);
-
-static void __exit sh_mipi_exit(void)
-{
-	platform_driver_unregister(&sh_mipi_driver);
-}
-module_exit(sh_mipi_exit);
+module_platform_driver_probe(sh_mipi_driver, sh_mipi_probe);
 
 MODULE_AUTHOR("Guennadi Liakhovetski <g.liakhovetski@gmx.de>");
 MODULE_DESCRIPTION("SuperH / ARM-shmobile MIPI DSI driver");
diff --git a/drivers/video/sh_mobile_hdmi.c b/drivers/video/sh_mobile_hdmi.c
index 930e550..bfe4728 100644
--- a/drivers/video/sh_mobile_hdmi.c
+++ b/drivers/video/sh_mobile_hdmi.c
@@ -1445,17 +1445,7 @@ static struct platform_driver sh_hdmi_driver = {
 	},
 };
 
-static int __init sh_hdmi_init(void)
-{
-	return platform_driver_probe(&sh_hdmi_driver, sh_hdmi_probe);
-}
-module_init(sh_hdmi_init);
-
-static void __exit sh_hdmi_exit(void)
-{
-	platform_driver_unregister(&sh_hdmi_driver);
-}
-module_exit(sh_hdmi_exit);
+module_platform_driver_probe(sh_hdmi_driver, sh_hdmi_probe);
 
 MODULE_AUTHOR("Guennadi Liakhovetski <g.liakhovetski@gmx.de>");
 MODULE_DESCRIPTION("SuperH / ARM-shmobile HDMI driver");
-- 
1.8.1.5

Re: [PATCH v4] drivers: video: use module_platform_driver_probe()

From: Fabio Porcedda <hidden>
Date: 2013-04-02 10:08:02

On Fri, Mar 15, 2013 at 2:02 PM, Fabio Porcedda
[off-list ref] wrote:
quoted hunk
This patch converts the drivers to use the
module_platform_driver_probe() macro which makes the code smaller and
a bit simpler.

Signed-off-by: Fabio Porcedda <redacted>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Acked-by: Nicolas Ferre <redacted> # atmel_lcdfb.c
Cc: Tomi Valkeinen <redacted>
Cc: David Howells <dhowells@redhat.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> # amifb.c
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---

Notes:
    v4:
     - add acked-by Nicolas & Laurent
     - fix amifb.c
    v3:
     - add missing drivers: amifb, atmel_lcdfb, vrfb
     - split patch set to each maintainer to easy up respin
    v2:
     - rebased over linux-next and remove already converted drivers

 drivers/video/amifb.c          | 14 +-------------
 drivers/video/atmel_lcdfb.c    | 13 +------------
 drivers/video/omap2/vrfb.c     | 13 +------------
 drivers/video/sh_mipi_dsi.c    | 12 +-----------
 drivers/video/sh_mobile_hdmi.c | 12 +-----------
 5 files changed, 5 insertions(+), 59 deletions(-)
diff --git a/drivers/video/amifb.c b/drivers/video/amifb.c
index 7fa1bf8..77cb4ff 100644
--- a/drivers/video/amifb.c
+++ b/drivers/video/amifb.c
@@ -3788,19 +3788,7 @@ static struct platform_driver amifb_driver = {
        },
 };

-static int __init amifb_init(void)
-{
-       return platform_driver_probe(&amifb_driver, amifb_probe);
-}
-
-module_init(amifb_init);
-
-static void __exit amifb_exit(void)
-{
-       platform_driver_unregister(&amifb_driver);
-}
-
-module_exit(amifb_exit);
+module_platform_driver_probe(amifb_driver, amifb_probe);

 MODULE_LICENSE("GPL");
 MODULE_ALIAS("platform:amiga-video");
diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c
index 12cf5f3..654e102 100644
--- a/drivers/video/atmel_lcdfb.c
+++ b/drivers/video/atmel_lcdfb.c
@@ -1150,18 +1150,7 @@ static struct platform_driver atmel_lcdfb_driver = {
        },
 };

-static int __init atmel_lcdfb_init(void)
-{
-       return platform_driver_probe(&atmel_lcdfb_driver, atmel_lcdfb_probe);
-}
-
-static void __exit atmel_lcdfb_exit(void)
-{
-       platform_driver_unregister(&atmel_lcdfb_driver);
-}
-
-module_init(atmel_lcdfb_init);
-module_exit(atmel_lcdfb_exit);
+module_platform_driver_probe(atmel_lcdfb_driver, atmel_lcdfb_probe);

 MODULE_DESCRIPTION("AT91/AT32 LCD Controller framebuffer driver");
 MODULE_AUTHOR("Nicolas Ferre <nicolas.ferre@atmel.com>");
diff --git a/drivers/video/omap2/vrfb.c b/drivers/video/omap2/vrfb.c
index 10560ef..5261229 100644
--- a/drivers/video/omap2/vrfb.c
+++ b/drivers/video/omap2/vrfb.c
@@ -397,18 +397,7 @@ static struct platform_driver vrfb_driver = {
        .remove         = __exit_p(vrfb_remove),
 };

-static int __init vrfb_init(void)
-{
-       return platform_driver_probe(&vrfb_driver, &vrfb_probe);
-}
-
-static void __exit vrfb_exit(void)
-{
-       platform_driver_unregister(&vrfb_driver);
-}
-
-module_init(vrfb_init);
-module_exit(vrfb_exit);
+module_platform_driver_probe(vrfb_driver, vrfb_probe);

 MODULE_AUTHOR("Tomi Valkeinen <tomi.valkeinen@ti.com>");
 MODULE_DESCRIPTION("OMAP VRFB");
diff --git a/drivers/video/sh_mipi_dsi.c b/drivers/video/sh_mipi_dsi.c
index 701b461..6cad530 100644
--- a/drivers/video/sh_mipi_dsi.c
+++ b/drivers/video/sh_mipi_dsi.c
@@ -581,17 +581,7 @@ static struct platform_driver sh_mipi_driver = {
        },
 };

-static int __init sh_mipi_init(void)
-{
-       return platform_driver_probe(&sh_mipi_driver, sh_mipi_probe);
-}
-module_init(sh_mipi_init);
-
-static void __exit sh_mipi_exit(void)
-{
-       platform_driver_unregister(&sh_mipi_driver);
-}
-module_exit(sh_mipi_exit);
+module_platform_driver_probe(sh_mipi_driver, sh_mipi_probe);

 MODULE_AUTHOR("Guennadi Liakhovetski <g.liakhovetski@gmx.de>");
 MODULE_DESCRIPTION("SuperH / ARM-shmobile MIPI DSI driver");
diff --git a/drivers/video/sh_mobile_hdmi.c b/drivers/video/sh_mobile_hdmi.c
index 930e550..bfe4728 100644
--- a/drivers/video/sh_mobile_hdmi.c
+++ b/drivers/video/sh_mobile_hdmi.c
@@ -1445,17 +1445,7 @@ static struct platform_driver sh_hdmi_driver = {
        },
 };

-static int __init sh_hdmi_init(void)
-{
-       return platform_driver_probe(&sh_hdmi_driver, sh_hdmi_probe);
-}
-module_init(sh_hdmi_init);
-
-static void __exit sh_hdmi_exit(void)
-{
-       platform_driver_unregister(&sh_hdmi_driver);
-}
-module_exit(sh_hdmi_exit);
+module_platform_driver_probe(sh_hdmi_driver, sh_hdmi_probe);

 MODULE_AUTHOR("Guennadi Liakhovetski <g.liakhovetski@gmx.de>");
 MODULE_DESCRIPTION("SuperH / ARM-shmobile HDMI driver");
--
1.8.1.5
ping

Regards
--
Fabio Porcedda

Re: [PATCH v4] drivers: video: use module_platform_driver_probe()

From: Tomi Valkeinen <hidden>
Date: 2013-04-02 10:21:07

On 2013-03-15 15:02, Fabio Porcedda wrote:
This patch converts the drivers to use the
module_platform_driver_probe() macro which makes the code smaller and
a bit simpler.

Signed-off-by: Fabio Porcedda <redacted>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Acked-by: Nicolas Ferre <redacted> # atmel_lcdfb.c
Cc: Tomi Valkeinen <redacted>
Cc: David Howells <dhowells@redhat.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> # amifb.c
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---

Notes:
    v4:
     - add acked-by Nicolas & Laurent
     - fix amifb.c
    v3:
     - add missing drivers: amifb, atmel_lcdfb, vrfb
     - split patch set to each maintainer to easy up respin
    v2:
     - rebased over linux-next and remove already converted drivers

 drivers/video/amifb.c          | 14 +-------------
 drivers/video/atmel_lcdfb.c    | 13 +------------
 drivers/video/omap2/vrfb.c     | 13 +------------
 drivers/video/sh_mipi_dsi.c    | 12 +-----------
 drivers/video/sh_mobile_hdmi.c | 12 +-----------
 5 files changed, 5 insertions(+), 59 deletions(-)
Thanks, applied to fbdev branch.

 Tomi

Re: [PATCH v4] drivers: video: use module_platform_driver_probe()

From: Fabio Porcedda <hidden>
Date: 2013-04-04 11:38:49

On Tue, Apr 2, 2013 at 12:21 PM, Tomi Valkeinen [off-list ref] wrote:
On 2013-03-15 15:02, Fabio Porcedda wrote:
quoted
This patch converts the drivers to use the
module_platform_driver_probe() macro which makes the code smaller and
a bit simpler.

Signed-off-by: Fabio Porcedda <redacted>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Acked-by: Nicolas Ferre <redacted> # atmel_lcdfb.c
Cc: Tomi Valkeinen <redacted>
Cc: David Howells <dhowells@redhat.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> # amifb.c
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---

Notes:
    v4:
     - add acked-by Nicolas & Laurent
     - fix amifb.c
    v3:
     - add missing drivers: amifb, atmel_lcdfb, vrfb
     - split patch set to each maintainer to easy up respin
    v2:
     - rebased over linux-next and remove already converted drivers

 drivers/video/amifb.c          | 14 +-------------
 drivers/video/atmel_lcdfb.c    | 13 +------------
 drivers/video/omap2/vrfb.c     | 13 +------------
 drivers/video/sh_mipi_dsi.c    | 12 +-----------
 drivers/video/sh_mobile_hdmi.c | 12 +-----------
 5 files changed, 5 insertions(+), 59 deletions(-)
Thanks, applied to fbdev branch.
Thanks for taking it.
I don't see this patch neither in linux-next nor in
git://gitorious.org/linux-omap-dss2/linux.git,
in which repository/branch is it?

Regards
--
Fabio Porcedda
 Tomi

Re: [PATCH v4] drivers: video: use module_platform_driver_probe()

From: Tomi Valkeinen <hidden>
Date: 2013-04-04 11:41:07

On 2013-04-04 14:38, Fabio Porcedda wrote:
On Tue, Apr 2, 2013 at 12:21 PM, Tomi Valkeinen [off-list ref] wrote:
quoted
On 2013-03-15 15:02, Fabio Porcedda wrote:
quoted
This patch converts the drivers to use the
module_platform_driver_probe() macro which makes the code smaller and
a bit simpler.

Signed-off-by: Fabio Porcedda <redacted>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Acked-by: Nicolas Ferre <redacted> # atmel_lcdfb.c
Cc: Tomi Valkeinen <redacted>
Cc: David Howells <dhowells@redhat.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> # amifb.c
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---

Notes:
    v4:
     - add acked-by Nicolas & Laurent
     - fix amifb.c
    v3:
     - add missing drivers: amifb, atmel_lcdfb, vrfb
     - split patch set to each maintainer to easy up respin
    v2:
     - rebased over linux-next and remove already converted drivers

 drivers/video/amifb.c          | 14 +-------------
 drivers/video/atmel_lcdfb.c    | 13 +------------
 drivers/video/omap2/vrfb.c     | 13 +------------
 drivers/video/sh_mipi_dsi.c    | 12 +-----------
 drivers/video/sh_mobile_hdmi.c | 12 +-----------
 5 files changed, 5 insertions(+), 59 deletions(-)
Thanks, applied to fbdev branch.
Thanks for taking it.
I don't see this patch neither in linux-next nor in
git://gitorious.org/linux-omap-dss2/linux.git,
in which repository/branch is it?
I just pushed for-next branch an hour ago or so, to the above mentioned
gitorious tree. So should be in linux-next tomorrow, I guess.

 Tomi

Re: [PATCH v4] drivers: video: use module_platform_driver_probe()

From: Fabio Porcedda <hidden>
Date: 2013-04-04 11:47:40

On Thu, Apr 4, 2013 at 1:41 PM, Tomi Valkeinen [off-list ref] wrote:
On 2013-04-04 14:38, Fabio Porcedda wrote:
quoted
On Tue, Apr 2, 2013 at 12:21 PM, Tomi Valkeinen [off-list ref] wrote:
quoted
On 2013-03-15 15:02, Fabio Porcedda wrote:
quoted
This patch converts the drivers to use the
module_platform_driver_probe() macro which makes the code smaller and
a bit simpler.

Signed-off-by: Fabio Porcedda <redacted>
Cc: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>
Acked-by: Nicolas Ferre <redacted> # atmel_lcdfb.c
Cc: Tomi Valkeinen <redacted>
Cc: David Howells <dhowells@redhat.com>
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> # amifb.c
Cc: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---

Notes:
    v4:
     - add acked-by Nicolas & Laurent
     - fix amifb.c
    v3:
     - add missing drivers: amifb, atmel_lcdfb, vrfb
     - split patch set to each maintainer to easy up respin
    v2:
     - rebased over linux-next and remove already converted drivers

 drivers/video/amifb.c          | 14 +-------------
 drivers/video/atmel_lcdfb.c    | 13 +------------
 drivers/video/omap2/vrfb.c     | 13 +------------
 drivers/video/sh_mipi_dsi.c    | 12 +-----------
 drivers/video/sh_mobile_hdmi.c | 12 +-----------
 5 files changed, 5 insertions(+), 59 deletions(-)
Thanks, applied to fbdev branch.
Thanks for taking it.
I don't see this patch neither in linux-next nor in
git://gitorious.org/linux-omap-dss2/linux.git,
in which repository/branch is it?
I just pushed for-next branch an hour ago or so, to the above mentioned
gitorious tree. So should be in linux-next tomorrow, I guess.
Thanks.

--
Fabio Porcedda
 Tomi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help