Re: BUG: circular locking dependency detected

2 messages, 1 author, 2013-01-31 · open the first message on its own page

Re: BUG: circular locking dependency detected

From: Sedat Dilek <hidden>
Date: 2013-01-31 10:12:06

[ CCing Linux-Next and MMOTM folks ]

Original posting from Daniel see [0]

[ QUOTE ]
On Thu, Jan 31, 2013 at 6:40 AM, Greg Kroah-Hartman
[off-list ref] wrote:
On Thu, Jan 31, 2013 at 11:26:53AM +1100, Linus Torvalds wrote:
quoted
On Thu, Jan 31, 2013 at 11:13 AM, Russell King [off-list ref] wrote:
quoted
Which may or may not be a good thing depending how you look at it; it
means that once your kernel blanks, you get a lockdep dump.  At that
point you lose lockdep checking for everything else because lockdep
disables itself after the first dump.
Fair enough, we may want to revert the lockdep checking for
console_lock, and make re-enabling it part of the patch-series that
fixes the locking.

Daniel/Dave? Does that sound reasonable?
Yeah, sounds good.
Reverting the patch is fine with me.  Just let me know so I can queue it
up again for 3.9.
Can you please also pick up the (currently) three locking fixups
around fbcon? Just so that we don't repeat the same fun where people
complain about lockdep splats, but the fixes are stuck somewhere. And
I guess Dave would be happy to not end up as fbcon maintainer ;-) He
has a git branch with them at
http://cgit.freedesktop.org/~airlied/linux/log/?hûcon-locking-fixes
though I have a small bikeshed on his last patch pending.
-Daniel
[ /QUOTE ]

Did the 3rd patch go also to mmotm tree and got marked for Linux-Next inclusion?
Best would be to have it in mainline, finally.
Please, fix that for-3.8!

Thanks to all volunteers (Alan, Andrew, Takashi Iwai (Sorry, dunno
which is 1st and last name), Daniel and finally Dave) trying to get
this incredible pain-in-the-a** upstream :-).

- Sedat -

[0] http://marc.info/?l=dri-devel&m5962051326601&w=2
[1] http://cgit.freedesktop.org/~airlied/linux/log/?hûcon-locking-fixes
[2] http://cgit.freedesktop.org/~airlied/linux/commit/?hûcon-locking-fixes&id˜dfe36b5532576dedf41408d5bbd45fa31ec62d

Re: BUG: circular locking dependency detected

From: Sedat Dilek <hidden>
Date: 2013-01-31 10:20:52

On Thu, Jan 31, 2013 at 11:12 AM, Sedat Dilek [off-list ref] wrote:
[ CCing Linux-Next and MMOTM folks ]

Original posting from Daniel see [0]

[ QUOTE ]
On Thu, Jan 31, 2013 at 6:40 AM, Greg Kroah-Hartman
[off-list ref] wrote:
quoted
On Thu, Jan 31, 2013 at 11:26:53AM +1100, Linus Torvalds wrote:
quoted
On Thu, Jan 31, 2013 at 11:13 AM, Russell King [off-list ref] wrote:
quoted
Which may or may not be a good thing depending how you look at it; it
means that once your kernel blanks, you get a lockdep dump.  At that
point you lose lockdep checking for everything else because lockdep
disables itself after the first dump.
Fair enough, we may want to revert the lockdep checking for
console_lock, and make re-enabling it part of the patch-series that
fixes the locking.

Daniel/Dave? Does that sound reasonable?
Yeah, sounds good.
quoted
Reverting the patch is fine with me.  Just let me know so I can queue it
up again for 3.9.
Can you please also pick up the (currently) three locking fixups
around fbcon? Just so that we don't repeat the same fun where people
complain about lockdep splats, but the fixes are stuck somewhere. And
I guess Dave would be happy to not end up as fbcon maintainer ;-) He
has a git branch with them at
http://cgit.freedesktop.org/~airlied/linux/log/?hûcon-locking-fixes
though I have a small bikeshed on his last patch pending.
-Daniel
[ /QUOTE ]

Did the 3rd patch go also to mmotm tree and got marked for Linux-Next inclusion?
Best would be to have it in mainline, finally.
Please, fix that for-3.8!

Thanks to all volunteers (Alan, Andrew, Takashi Iwai (Sorry, dunno
which is 1st and last name), Daniel and finally Dave) trying to get
this incredible pain-in-the-a** upstream :-).

- Sedat -

[0] http://marc.info/?l=dri-devel&m5962051326601&w=2
[1] http://cgit.freedesktop.org/~airlied/linux/log/?hûcon-locking-fixes
[2] http://cgit.freedesktop.org/~airlied/linux/commit/?hûcon-locking-fixes&id˜dfe36b5532576dedf41408d5bbd45fa31ec62d
[ Adjusting outdated email-adresses, CC Borislav ]

What's with the patch from [3] in mmotm? For-3.8, no more needed?

- Sedat -

[3] http://ozlabs.org/~akpm/mmots/broken-out/drm-fb-helper-dont-sleep-for-screen-unblank-when-an-oopps-is-in-progress.patch
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help