# \[PATCH\] pwm-backlight: handle BL\_CORE\_FBBLANK state - Subsystems: FRAMEBUFFER LAYER, BACKLIGHT CLASS/SUBSYSTEM, THE REST - Maintainers: Helge Deller, Lee Jones, Daniel Thompson, Jingoo Han, Linus Torvalds - List: linux-fbdev - 2 messages, 2 authors - Page: https://ratatoskr.run/linux-fbdev/2013/01/3993205/t ## \[PATCH\] pwm-backlight: handle BL\_CORE\_FBBLANK state - From: Alexandre Courbot \ - Date: 2013-01-30 06:19:54 - Message: https://ratatoskr.run/linux-fbdev/2013/01/3993205.md ```text According to include/linux/backlight.h, the fb_blank field is to be removed and blank status should preferably be set by setting the BL_CORE_FBBLANK bit of the state field. This patch ensures this condition is also taken into account when updating the backlight state. Signed-off-by: Alexandre Courbot --- drivers/video/backlight/pwm_bl.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/video/backlight/pwm_bl.c b/drivers/video/backlight/pwm_bl.c index 069983c..4af6d13 100644 --- a/drivers/video/backlight/pwm_bl.c +++ b/drivers/video/backlight/pwm_bl.c @@ -41,10 +41,9 @@ static int pwm_backlight_update_status(struct backlight_device *bl) int brightness = bl->props.brightness; int max = bl->props.max_brightness; - if (bl->props.power != FB_BLANK_UNBLANK) - brightness = 0; - - if (bl->props.fb_blank != FB_BLANK_UNBLANK) + if (bl->props.power != FB_BLANK_UNBLANK || + bl->props.fb_blank != FB_BLANK_UNBLANK || + bl->props.state & BL_CORE_FBBLANK) brightness = 0; if (pb->notify) -- 1.8.1.2 ``` ## Re: \[PATCH\] pwm-backlight: handle BL\_CORE\_FBBLANK state - From: Thierry Reding \ - Date: 2013-01-30 07:58:48 - Message: https://ratatoskr.run/linux-fbdev/2013/01/3993273.md ```text On Wed, Jan 30, 2013 at 03:19:15PM +0900, Alexandre Courbot wrote: > According to include/linux/backlight.h, the fb_blank field is to be > removed and blank status should preferably be set by setting the > BL_CORE_FBBLANK bit of the state field. This patch ensures this > condition is also taken into account when updating the backlight state. > > Signed-off-by: Alexandre Courbot > --- > drivers/video/backlight/pwm_bl.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) Applied, thanks. Thierry ```