# Re: \[git pull\] fbcon locking fixes.

- From: Maarten Lankhorst \<hidden\>
- Date: 2013-01-28 12:45:57 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2013/01/3992021
- Thread: https://ratatoskr.run/linux-fbdev/2013/01/3990302/t.md

```text
Hey,

Op 25-01-13 02:45, Dave Airlie schreef:
> On Fri, Jan 25, 2013 at 11:06 AM, Dave Airlie [ref] wrote:
>> On Fri, Jan 25, 2013 at 10:53 AM, Linus Torvalds
>> [ref] wrote:
>>> On Thu, Jan 24, 2013 at 4:42 PM, Dave Airlie [ref] wrote:
>>>> These patches have been sailing around long enough, waiting for a maintainer
>>>> to reappear, so I've decided enough is enough, lockdep is kinda useful to have.
>>> Last this was tried, these patches failed miserably.
>>>
>>> They caused instant lockdep splat and then a total lockup with efifb.
>>> It may be that Takashi's patch helps fix that problem, but it's in no
>>> way clear that it does, so the patch series isn't at all obviously
>>> stable.
>>>
>>> Yes, lockdep is indeed "kinda useful", and there clearly are locking
>>> problems in fbdev. But I'm not seeing myself pulling these for 3.8.
>>> They've been too problematic to pull in at this late stage.
>>>
>> Okay I'll fix the efifb problem and then maybe queue them for -next.
> Okay I've just sent out another fbcon patch to fix the locking harder.
>
> There was a path going into set_con2fb_path if an fb driver was
> already registered, I just pushed the locking out further on anyone
> going in there.
>
> it boots on my EFI macbook here.
>
I cherry picked those patches to my tree, and the full series no longer triggers a lockdep warning.
It also no longer locks up during modprobing or vga-switcheroo either.

Tested-by: Maarten Lankhorst <redacted>

~Maarten
```