# Re: 3.8-rc2: EFI framebuffer lock inversion... - List: linux-fbdev - 5 messages, 2 authors - Page: https://ratatoskr.run/linux-fbdev/2013/01/3977974/t ## Re: 3.8-rc2: EFI framebuffer lock inversion... - From: Sedat Dilek \ - Date: 2013-01-03 14:11:42 - Message: https://ratatoskr.run/linux-fbdev/2013/01/3977974.md ```text Hi Daniel, just wanted to test the fb-fix [2] from Alan and followed the thread in [1]. Me is also working with i915 KMS. I looked at nouveau KMS driver and adapted the part for i915: drivers/gpu/drm/nouveau/nouveau_drm.c-200- /* remove conflicting drivers (vesafb, efifb etc) */ drivers/gpu/drm/nouveau/nouveau_drm.c:201: aper = alloc_apertures(3); drivers/gpu/drm/nouveau/nouveau_drm.c-202- if (!aper) drivers/gpu/drm/nouveau/nouveau_drm.c-203- return -ENOMEM; Untested by me, feel free to test. Maybe some of the i915 and/or fb driver experts can comment on the problem. Regards, - Sedat - [1] http://marc.info/?t=135721787600001&r=1&w=2 [2] https://patchwork.kernel.org/patch/1757061/ ``` ## Re: 3.8-rc2: EFI framebuffer lock inversion... - From: Daniel J Blueman \ - Date: 2013-01-03 14:39:36 - Message: https://ratatoskr.run/linux-fbdev/2013/01/3977987.md ```text On 3 January 2013 22:11, Sedat Dilek [ref] wrote: > Hi Daniel, > > just wanted to test the fb-fix [2] from Alan and followed the thread in [1]. > Me is also working with i915 KMS. > > I looked at nouveau KMS driver and adapted the part for i915: > > drivers/gpu/drm/nouveau/nouveau_drm.c-200- /* remove conflicting > drivers (vesafb, efifb etc) */ > drivers/gpu/drm/nouveau/nouveau_drm.c:201: aper = alloc_apertures(3); > drivers/gpu/drm/nouveau/nouveau_drm.c-202- if (!aper) > drivers/gpu/drm/nouveau/nouveau_drm.c-203- return -ENOMEM; > > Untested by me, feel free to test. > > Maybe some of the i915 and/or fb driver experts can comment on the problem. The structure array from alloc_apertures is just used for the PCI base address registers, so it's important here. I'll take a look at the efifb locking later. Thanks, Daniel -- Daniel J Blueman ``` ## Re: 3.8-rc2: EFI framebuffer lock inversion... - From: Sedat Dilek \ - Date: 2013-01-03 15:09:41 - Message: https://ratatoskr.run/linux-fbdev/2013/01/3978001.md ```text On Thu, Jan 3, 2013 at 3:39 PM, Daniel J Blueman [ref] wrote: > On 3 January 2013 22:11, Sedat Dilek [ref] wrote: >> Hi Daniel, >> >> just wanted to test the fb-fix [2] from Alan and followed the thread in [1]. >> Me is also working with i915 KMS. >> >> I looked at nouveau KMS driver and adapted the part for i915: >> >> drivers/gpu/drm/nouveau/nouveau_drm.c-200- /* remove conflicting >> drivers (vesafb, efifb etc) */ >> drivers/gpu/drm/nouveau/nouveau_drm.c:201: aper = alloc_apertures(3); >> drivers/gpu/drm/nouveau/nouveau_drm.c-202- if (!aper) >> drivers/gpu/drm/nouveau/nouveau_drm.c-203- return -ENOMEM; >> >> Untested by me, feel free to test. >> >> Maybe some of the i915 and/or fb driver experts can comment on the problem. > > The structure array from alloc_apertures is just used for the PCI base > address registers, so it's important here. > > I'll take a look at the efifb locking later. > That is the code part [1] I looked at. Maybe the next lines with ap(er)->ranges || pci_resource_start() and pci_resource_len() are missing? I also looked at "include/linux/fb.h" but could not get wiser. Also I can't say what the value "1" or "3" means in alloc_apertures(). Wouldn't it make sense to remove the conflicting fb-drivers globally not in each affected DRM/KMS driver? Just an idea. - Sedat - [1] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob;f=drivers/gpu/drm/nouveau/nouveau_drm.c;hb=refs/tags/v3.8-rc2#l192 > Thanks, > Daniel > -- > Daniel J Blueman ``` ## Re: 3.8-rc2: EFI framebuffer lock inversion... - From: Sedat Dilek \ - Date: 2013-01-03 15:36:10 - Message: https://ratatoskr.run/linux-fbdev/2013/01/3978010.md ```text On Thu, Jan 3, 2013 at 3:11 PM, Sedat Dilek [ref] wrote: > Hi Daniel, > > just wanted to test the fb-fix [2] from Alan and followed the thread in [1]. > Me is also working with i915 KMS. > > I looked at nouveau KMS driver and adapted the part for i915: > > drivers/gpu/drm/nouveau/nouveau_drm.c-200- /* remove conflicting > drivers (vesafb, efifb etc) */ > drivers/gpu/drm/nouveau/nouveau_drm.c:201: aper = alloc_apertures(3); > drivers/gpu/drm/nouveau/nouveau_drm.c-202- if (!aper) > drivers/gpu/drm/nouveau/nouveau_drm.c-203- return -ENOMEM; > > Untested by me, feel free to test. > > Maybe some of the i915 and/or fb driver experts can comment on the problem. > That is the i915 part [---> i915_kick_out_firmware_fb()] where I looked at [1]. - Sedat - [1] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=blob;f=drivers/gpu/drm/i915/i915_dma.c;hb=refs/tags/v3.8-rc2#l1393 > Regards, > - Sedat - > > [1] http://marc.info/?t5721787600001&r=1&w=2 > [2] https://patchwork.kernel.org/patch/1757061/ ``` ## Re: 3.8-rc2: EFI framebuffer lock inversion... - From: Sedat Dilek \ - Date: 2013-01-04 10:49:11 - Message: https://ratatoskr.run/linux-fbdev/2013/01/3978399.md ```text On Thu, Jan 3, 2013 at 3:39 PM, Daniel J Blueman [ref] wrote: > On 3 January 2013 22:11, Sedat Dilek [ref] wrote: >> Hi Daniel, >> >> just wanted to test the fb-fix [2] from Alan and followed the thread in [1]. >> Me is also working with i915 KMS. >> >> I looked at nouveau KMS driver and adapted the part for i915: >> >> drivers/gpu/drm/nouveau/nouveau_drm.c-200- /* remove conflicting >> drivers (vesafb, efifb etc) */ >> drivers/gpu/drm/nouveau/nouveau_drm.c:201: aper = alloc_apertures(3); >> drivers/gpu/drm/nouveau/nouveau_drm.c-202- if (!aper) >> drivers/gpu/drm/nouveau/nouveau_drm.c-203- return -ENOMEM; >> >> Untested by me, feel free to test. >> >> Maybe some of the i915 and/or fb driver experts can comment on the problem. > > The structure array from alloc_apertures is just used for the PCI base > address registers, so it's important here. > > I'll take a look at the efifb locking later. > You had a chance to look at this? - Sedat - > Thanks, > Daniel > -- > Daniel J Blueman ```