# Re: \[PATCH 2/2\] drivers/video: fsl-diu-fb: fix bugs in interrupt handling

- From: Anatolij Gustschin \<agust@denx.de\>
- Date: 2013-01-17 23:11:07 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2013/01/13464551
- Thread: https://ratatoskr.run/linux-fbdev/2013/01/13464549/t.md

```text
On Thu, 17 Jan 2013 16:20:04 -0600
Timur Tabi [ref] wrote:
...
> This is why you need hacks like can_handle_irq.  So I'm not crazy about
> this patch.  I think you need to get rid of can_handle_irq and allow the
> interrupt handler to be registered before the hardware is initialized.

It makes sense. More testing shows that disabling interrupts in
fsl_diu_release() needs to be fixed, too. If the fb0 plane is opened
(i.e. by fbcon) and another app opens an overlay plane i.e. on /dev/fb1
and then closes it, the diu interrupts will be disabled, even though the
first plane is still opened.

Thanks,

Anatolij
```