# Re: \[PATCH 1/2\] drivers/video: fsl-diu-fb: fix pixel formats for 24 and 16 bpp

- From: Timur Tabi \<hidden\>
- Date: 2013-01-17 23:08:25 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2013/01/13464534
- Thread: https://ratatoskr.run/linux-fbdev/2013/01/13464530/t.md

```text
Anatolij Gustschin wrote:
> Framebuffer colors for 24 and 16 bpp are currently wrong. The order
> of the color component arguments in the MAKE_PF() is not natural
> and causes some confusion. The generated pixel format values for 24
> and 16 bpp depths do not much the values in the comments.
> 
> Fix the macro arguments to be in the natural RGB order and adjust
> the arguments for all depths to generate correct pixel format values
> (equal to the values mentioned in the comments).
> 
> Signed-off-by: Anatolij Gustschin <agust@denx.de>
> Cc: Timur Tabi <redacted>

Acked-by: Timur Tabi <redacted>

-- 
Timur Tabi
```