[PATCH] video: exynos_mipi_dsi: Add missing mutex_unlock

STALE4994d

2 messages, 2 authors, 2012-12-17 · open the first message on its own page

[PATCH] video: exynos_mipi_dsi: Add missing mutex_unlock

From: Jonghwan Choi <hidden>
Date: 2012-12-14 08:33:15

Add a mutex_unlock on the error path.

Signed-off-by: Jonghwan Choi <redacted>
---
 drivers/video/exynos/exynos_mipi_dsi_common.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/video/exynos/exynos_mipi_dsi_common.c
b/drivers/video/exynos/exynos_mipi_dsi_common.c
index 3cd29a4..bd7f4f2 100644
--- a/drivers/video/exynos/exynos_mipi_dsi_common.c
+++ b/drivers/video/exynos/exynos_mipi_dsi_common.c
@@ -377,6 +377,7 @@ int exynos_mipi_dsi_rd_data(struct mipi_dsim_device
*dsim, unsigned int data_id,
 			"data id %x is not supported current DSI spec.\n",
 			data_id);
 
+		mutex_unlock(&dsim->lock);
 		return -EINVAL;
 	}
 
-- 
1.7.4.1

Re: [PATCH] video: exynos_mipi_dsi: Add missing mutex_unlock

From: Donghwa Lee <hidden>
Date: 2012-12-17 01:31:20

  On Fri, Dec 14, 2012 at 17:33, Jonghwan Choi wrote:
quoted hunk
Add a mutex_unlock on the error path.

Signed-off-by: Jonghwan Choi<redacted>
---
  drivers/video/exynos/exynos_mipi_dsi_common.c |    1 +
  1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/video/exynos/exynos_mipi_dsi_common.c
b/drivers/video/exynos/exynos_mipi_dsi_common.c
index 3cd29a4..bd7f4f2 100644
--- a/drivers/video/exynos/exynos_mipi_dsi_common.c
+++ b/drivers/video/exynos/exynos_mipi_dsi_common.c
@@ -377,6 +377,7 @@ int exynos_mipi_dsi_rd_data(struct mipi_dsim_device
*dsim, unsigned int data_id,
  			"data id %x is not supported current DSI spec.\n",
  			data_id);
  
+		mutex_unlock(&dsim->lock);
  		return -EINVAL;
  	}
  
It looks good to me.

Acked-by: Donghwa Lee <redacted>

Thank you,
Donghwa Lee
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help