# Re: \[PATCH v3\] video: Versatile Express DVI output driver

- From: Arnd Bergmann \<arnd@arndb.de\>
- Date: 2012-11-19 15:43:51 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2012/11/8625765
- Thread: https://ratatoskr.run/linux-arm-kernel/2012/10/8621429/t.md

```text
On Monday 19 November 2012, Pawel Moll wrote:
> I've asked the framebuffer people 3 times about this but got no comment
> whatsoever:
> 
> https://patchwork.kernel.org/patch/1473091/
> https://patchwork.kernel.org/patch/1601781/
> 
> so I assume there is no problem with merging this code ;-) Therefore,
> would you be so kind to pull this single patch? Without it the 3.8
> kernel will not be able to show anything on VE's display...

Hi Pawel,

I have two comments for the patch that need to be fixed:

* vexpress_dvi_fb_select uses the 'fb' argument as an index into
  the registered_fb array, but does not check for overflow against
  FB_MAX. I think you need to use get_fb_info().

* There is no documentation for the newly introduced sysfs interface.

	Arnd
```