Re: [PATCH v8 2/6] video: add of helper for videomode

On 11/13/2012 7:51 AM, Thierry Reding wrote:

On Tue, Nov 13, 2012 at 10:46:53AM -0700, Stephen Warren wrote:

quoted

On 11/13/2012 04:08 AM, Thierry Reding wrote:

quoted

On Mon, Nov 12, 2012 at 04:37:02PM +0100, Steffen Trumtrar wrote:

quoted

This adds support for reading display timings from DT or/and
convert one of those timings to a videomode. The
of_display_timing implementation supports multiple children where
each property can have up to 3 values. All children are read into
an array, that can be queried. of_get_videomode converts exactly
one of that timings to a struct videomode.

quoted

quoted

diff --git
a/Documentation/devicetree/bindings/video/display-timings.txt
b/Documentation/devicetree/bindings/video/display-timings.txt

quoted

quoted

+ - clock-frequency: displayclock in Hz

"display clock"?

I /think/ I had suggested naming this clock-frequency before so that
the property name would be more standardized; other bindings use that
same name. But I'm not too attached to the name I guess.

That's not what I meant. I think "displayclock" should be two words in
the description of the property. The property name is fine.

Given that modern display engines often have numerous clocks, perhaps it
would be better to use a more specific name, like for example "pixel-clock".

Thierry



_______________________________________________
devicetree-discuss mailing list
devicetree-discuss@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/devicetree-discuss

On Tue, Nov 13, 2012 at 08:13:31AM -1000, Mitch Bradley wrote:

On 11/13/2012 7:51 AM, Thierry Reding wrote:

quoted

On Tue, Nov 13, 2012 at 10:46:53AM -0700, Stephen Warren wrote:

quoted

On 11/13/2012 04:08 AM, Thierry Reding wrote:

quoted

On Mon, Nov 12, 2012 at 04:37:02PM +0100, Steffen Trumtrar wrote:

quoted

This adds support for reading display timings from DT or/and
convert one of those timings to a videomode. The
of_display_timing implementation supports multiple children where
each property can have up to 3 values. All children are read into
an array, that can be queried. of_get_videomode converts exactly
one of that timings to a struct videomode.

quoted

quoted

diff --git
a/Documentation/devicetree/bindings/video/display-timings.txt
b/Documentation/devicetree/bindings/video/display-timings.txt

quoted

quoted

+ - clock-frequency: displayclock in Hz

"display clock"?

I /think/ I had suggested naming this clock-frequency before so that
the property name would be more standardized; other bindings use that
same name. But I'm not too attached to the name I guess.

That's not what I meant. I think "displayclock" should be two words in
the description of the property. The property name is fine.

Given that modern display engines often have numerous clocks, perhaps it
would be better to use a more specific name, like for example "pixel-clock".

This binding is only about defining display modes. Are any of the clocks
that you're referring to relevant to the actual display modes?

Thierry