# \[PATCH 1/1\] video: softcursor: Remove redundant NULL check before kfree - From: Sachin Kamat \ - Date: 2012-11-20 09:19:05 - List: linux-fbdev - Page: https://ratatoskr.run/linux-fbdev/2012/11/13464462 - Thread: https://ratatoskr.run/linux-fbdev/2012/11/13464462/t.md ```text kfree on a NULL pointer is a no-op. Signed-off-by: Sachin Kamat --- drivers/video/console/softcursor.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/video/console/softcursor.c b/drivers/video/console/softcursor.c index 25f835b..46dd8f5 100644 --- a/drivers/video/console/softcursor.c +++ b/drivers/video/console/softcursor.c @@ -35,8 +35,7 @@ int soft_cursor(struct fb_info *info, struct fb_cursor *cursor) dsize = s_pitch * cursor->image.height; if (dsize + sizeof(struct fb_image) != ops->cursor_size) { - if (ops->cursor_src != NULL) - kfree(ops->cursor_src); + kfree(ops->cursor_src); ops->cursor_size = dsize + sizeof(struct fb_image); ops->cursor_src = kmalloc(ops->cursor_size, GFP_ATOMIC); -- 1.7.4.1 ```