# Re: \[PATCH 1/7\] OMAPDSS: DISPC: Move burst\_size and buffer\_size to dispc\_features

- From: Tomi Valkeinen \<hidden\>
- Date: 2012-11-29 12:01:23 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2012/11/13464329
- Thread: https://ratatoskr.run/linux-omap/2012/11/13464440/t.md

```text
On 2012-11-28 12:41, Chandrabhanu Mahapatra wrote:
> The burst_size and buffer_size being local data to DISPC are moved to
> dispc_features and so removed from struct omap_dss_features. The functions
> referring to burst and buffer size are also removed from dss_features.c as they
> are now accessed locally in dispc.c.
> 
> Signed-off-by: Chandrabhanu Mahapatra <redacted>
> ---
>  drivers/video/omap2/dss/dispc.c        |   21 +++++++++++++++++----
>  drivers/video/omap2/dss/dss_features.c |   29 -----------------------------
>  drivers/video/omap2/dss/dss_features.h |    3 ---
>  3 files changed, 17 insertions(+), 36 deletions(-)
> 
> diff --git a/drivers/video/omap2/dss/dispc.c b/drivers/video/omap2/dss/dispc.c
> index 3d0ff5b..9f259ba 100644
> --- a/drivers/video/omap2/dss/dispc.c
> +++ b/drivers/video/omap2/dss/dispc.c
> @@ -104,6 +104,9 @@ struct dispc_features {
>  
>  	/* swap GFX & WB fifos */
>  	bool gfx_fifo_workaround:1;
> +
> +	u32 buffer_size_unit;
> +	u32 burst_size_unit;

Can you add the comments "in bytes" to these. Otherwise this looks good.

 Tomi


```

## Attachments

- [signature.asc](https://ratatoskr.run/linux-fbdev/2012/11/13464329/attachment/0) (application/pgp-signature, 899 bytes)