# \[PATCH\] da8xx: Fix revision check on the da8xx driver - Subsystems: FRAMEBUFFER LAYER, THE REST - Maintainers: Helge Deller, Linus Torvalds - List: linux-fbdev - 4 messages, 3 authors - Page: https://ratatoskr.run/linux-fbdev/2012/10/3948849/t ## \[PATCH\] da8xx: Fix revision check on the da8xx driver - From: Pantelis Antoniou \ - Date: 2012-10-30 18:14:23 - Message: https://ratatoskr.run/linux-fbdev/2012/10/3948849.md ```text The revision check fails for the beaglebone; Add new revision ID. Signed-off-by: Pantelis Antoniou --- drivers/video/da8xx-fb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c index 80665f6..866d804 100644 --- a/drivers/video/da8xx-fb.c +++ b/drivers/video/da8xx-fb.c @@ -1283,6 +1283,7 @@ static int __devinit fb_probe(struct platform_device *device) lcd_revision = LCD_VERSION_1; break; case 0x4F200800: + case 0x4F201000: lcd_revision = LCD_VERSION_2; break; default: -- 1.7.12 ``` ## RE: \[PATCH\] da8xx: Fix revision check on the da8xx driver - From: Manjunathappa, Prakash \ - Date: 2012-10-31 03:51:50 - Message: https://ratatoskr.run/linux-fbdev/2012/10/3949248.md ```text On Wed, Oct 31, 2012 at 21:26:24, Pantelis Antoniou wrote: > The revision check fails for the beaglebone; Add new revision ID. > > Signed-off-by: Pantelis Antoniou > --- > drivers/video/da8xx-fb.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c > index 80665f6..866d804 100644 > --- a/drivers/video/da8xx-fb.c > +++ b/drivers/video/da8xx-fb.c > @@ -1283,6 +1283,7 @@ static int __devinit fb_probe(struct platform_device *device) > lcd_revision = LCD_VERSION_1; > break; > case 0x4F200800: > + case 0x4F201000: Thanks for Correcting. This is the LCDC revision on am335x silicon in comparison with to one read(0x4F200800) on emulator platform. Acked-by: Manjunathappa, Prakash > lcd_revision = LCD_VERSION_2; > break; > default: > -- > 1.7.12 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ``` ## RE: \[PATCH\] da8xx: Fix revision check on the da8xx driver - From: Manjunathappa, Prakash \ - Date: 2012-12-04 06:36:25 - Message: https://ratatoskr.run/linux-fbdev/2012/12/3967260.md ```text Hi Tomi, On Wed, Oct 31, 2012 at 09:21:35, Manjunathappa, Prakash wrote: > On Wed, Oct 31, 2012 at 21:26:24, Pantelis Antoniou wrote: > > The revision check fails for the beaglebone; Add new revision ID. > > > > Signed-off-by: Pantelis Antoniou > > --- > > drivers/video/da8xx-fb.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c > > index 80665f6..866d804 100644 > > --- a/drivers/video/da8xx-fb.c > > +++ b/drivers/video/da8xx-fb.c > > @@ -1283,6 +1283,7 @@ static int __devinit fb_probe(struct platform_device *device) > > lcd_revision = LCD_VERSION_1; > > break; > > case 0x4F200800: > > + case 0x4F201000: > > Thanks for Correcting. This is the LCDC revision on am335x silicon in comparison > with to one read(0x4F200800) on emulator platform. > > Acked-by: Manjunathappa, Prakash > This patch is necessary for am335x FB, I could not see in your for-next branch, could you please consider this patch for 3.8 merge window. There are no pending review comments on this. Thanks, Prakash > > lcd_revision = LCD_VERSION_2; > > break; > > default: > > -- > > 1.7.12 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > > -- > To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > ``` ## Re: \[PATCH\] da8xx: Fix revision check on the da8xx driver - From: Tomi Valkeinen \ - Date: 2012-12-04 09:18:54 - Message: https://ratatoskr.run/linux-fbdev/2012/12/3967335.md ```text On 2012-12-04 08:36, Manjunathappa, Prakash wrote: > Hi Tomi, > > On Wed, Oct 31, 2012 at 09:21:35, Manjunathappa, Prakash wrote: >> On Wed, Oct 31, 2012 at 21:26:24, Pantelis Antoniou wrote: >>> The revision check fails for the beaglebone; Add new revision ID. >>> >>> Signed-off-by: Pantelis Antoniou >>> --- >>> drivers/video/da8xx-fb.c | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/drivers/video/da8xx-fb.c b/drivers/video/da8xx-fb.c >>> index 80665f6..866d804 100644 >>> --- a/drivers/video/da8xx-fb.c >>> +++ b/drivers/video/da8xx-fb.c >>> @@ -1283,6 +1283,7 @@ static int __devinit fb_probe(struct platform_device *device) >>> lcd_revision = LCD_VERSION_1; >>> break; >>> case 0x4F200800: >>> + case 0x4F201000: >> >> Thanks for Correcting. This is the LCDC revision on am335x silicon in comparison >> with to one read(0x4F200800) on emulator platform. >> >> Acked-by: Manjunathappa, Prakash >> > > This patch is necessary for am335x FB, I could not see in your for-next branch, I have only applied the patches that have been sent to me. > could you please consider this patch for 3.8 merge window. There are no pending > review comments on this. Applied. Tomi ```