[PATCH] da8xx: Allow use by am33xx based devices

Subsystems: framebuffer layer, the rest

STALE4979d

7 messages, 4 authors, 2013-01-07 · open the first message on its own page

[PATCH] da8xx: Allow use by am33xx based devices

From: Pantelis Antoniou <hidden>
Date: 2012-10-30 18:12:49

This driver can be used for AM33xx devices, like the popular beaglebone.

Signed-off-by: Pantelis Antoniou <redacted>
---
 drivers/video/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index 9791d10..e7868d8 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -2202,7 +2202,7 @@ config FB_SH7760
 
 config FB_DA8XX
 	tristate "DA8xx/OMAP-L1xx Framebuffer support"
-	depends on FB && ARCH_DAVINCI_DA8XX
+	depends on FB && (ARCH_DAVINCI_DA8XX || SOC_AM33XX)
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
 	select FB_CFB_IMAGEBLIT
-- 
1.7.12

RE: [PATCH] da8xx: Allow use by am33xx based devices

From: Manjunathappa, Prakash <hidden>
Date: 2012-10-31 05:23:22

Hi,

On Wed, Oct 31, 2012 at 21:26:08, Pantelis Antoniou wrote:
quoted hunk
This driver can be used for AM33xx devices, like the popular beaglebone.

Signed-off-by: Pantelis Antoniou <redacted>
---
 drivers/video/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index 9791d10..e7868d8 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -2202,7 +2202,7 @@ config FB_SH7760
 
 config FB_DA8XX
 	tristate "DA8xx/OMAP-L1xx Framebuffer support"
-	depends on FB && ARCH_DAVINCI_DA8XX
+	depends on FB && (ARCH_DAVINCI_DA8XX || SOC_AM33XX)
Agreed this is present on da8xx and am33xx, but moving forward for
supporting DT, we should be avoiding these dependencies. So instead
change this to remove machine dependencies.

Thanks,
Prakash
 	select FB_CFB_FILLRECT
 	select FB_CFB_COPYAREA
 	select FB_CFB_IMAGEBLIT
-- 
1.7.12

--
To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] da8xx: Allow use by am33xx based devices

From: Manjunathappa, Prakash <hidden>
Date: 2012-12-06 08:08:32

Hi Tomi,

On Wed, Oct 31, 2012 at 10:52:59, Manjunathappa, Prakash wrote:
Hi,

On Wed, Oct 31, 2012 at 21:26:08, Pantelis Antoniou wrote:
quoted
This driver can be used for AM33xx devices, like the popular beaglebone.

Signed-off-by: Pantelis Antoniou <redacted>
---
 drivers/video/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index 9791d10..e7868d8 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -2202,7 +2202,7 @@ config FB_SH7760
 
 config FB_DA8XX
 	tristate "DA8xx/OMAP-L1xx Framebuffer support"
-	depends on FB && ARCH_DAVINCI_DA8XX
+	depends on FB && (ARCH_DAVINCI_DA8XX || SOC_AM33XX)
Agreed this is present on da8xx and am33xx, but moving forward for
supporting DT, we should be avoiding these dependencies. So instead
change this to remove machine dependencies.
I could be wrong here, having dependency on platform seems to be right.
Otherwise may lead to build errors for other platforms. Please ignore my
comments and accept this patch.

Thanks,
Prakash

Re: [PATCH] da8xx: Allow use by am33xx based devices

From: Vaibhav Hiremath <hidden>
Date: 2012-12-10 09:02:26


On 12/6/2012 1:38 PM, Manjunathappa, Prakash wrote:
Hi Tomi,

On Wed, Oct 31, 2012 at 10:52:59, Manjunathappa, Prakash wrote:
quoted
Hi,

On Wed, Oct 31, 2012 at 21:26:08, Pantelis Antoniou wrote:
quoted
This driver can be used for AM33xx devices, like the popular beaglebone.

Signed-off-by: Pantelis Antoniou <redacted>
---
 drivers/video/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index 9791d10..e7868d8 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -2202,7 +2202,7 @@ config FB_SH7760
 
 config FB_DA8XX
 	tristate "DA8xx/OMAP-L1xx Framebuffer support"
-	depends on FB && ARCH_DAVINCI_DA8XX
+	depends on FB && (ARCH_DAVINCI_DA8XX || SOC_AM33XX)
Agreed this is present on da8xx and am33xx, but moving forward for
supporting DT, we should be avoiding these dependencies. So instead
change this to remove machine dependencies.
I could be wrong here, having dependency on platform seems to be right.
Otherwise may lead to build errors for other platforms. 
No, it should not result in to build error unless driver uses some
platform specific api's.

Thanks,
Vaibhav
Please ignore my
comments and accept this patch.

Thanks,
Prakash
_______________________________________________
Davinci-linux-open-source mailing list
Davinci-linux-open-source@linux.davincidsp.com
http://linux.davincidsp.com/mailman/listinfo/davinci-linux-open-source

RE: [PATCH] da8xx: Allow use by am33xx based devices

From: Manjunathappa, Prakash <hidden>
Date: 2012-12-12 07:20:42

Hi Vaibhav,

On Mon, Dec 10, 2012 at 14:32:06, Hiremath, Vaibhav wrote:

On 12/6/2012 1:38 PM, Manjunathappa, Prakash wrote:
quoted
Hi Tomi,

On Wed, Oct 31, 2012 at 10:52:59, Manjunathappa, Prakash wrote:
quoted
Hi,

On Wed, Oct 31, 2012 at 21:26:08, Pantelis Antoniou wrote:
quoted
This driver can be used for AM33xx devices, like the popular beaglebone.

Signed-off-by: Pantelis Antoniou <redacted>
---
 drivers/video/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index 9791d10..e7868d8 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -2202,7 +2202,7 @@ config FB_SH7760
 
 config FB_DA8XX
 	tristate "DA8xx/OMAP-L1xx Framebuffer support"
-	depends on FB && ARCH_DAVINCI_DA8XX
+	depends on FB && (ARCH_DAVINCI_DA8XX || SOC_AM33XX)
Agreed this is present on da8xx and am33xx, but moving forward for
supporting DT, we should be avoiding these dependencies. So instead
change this to remove machine dependencies.
I could be wrong here, having dependency on platform seems to be right.
Otherwise may lead to build errors for other platforms. 
No, it should not result in to build error unless driver uses some
platform specific api's.
Agreed, should not result in build error. But is it ok to show this option
on the platforms which do not have this IP?

Thanks,
Prakash

RE: [PATCH] da8xx: Allow use by am33xx based devices

From: Hiremath, Vaibhav <hidden>
Date: 2012-12-12 08:01:12

On Wed, Dec 12, 2012 at 12:50:28, Manjunathappa, Prakash wrote:
Hi Vaibhav,

On Mon, Dec 10, 2012 at 14:32:06, Hiremath, Vaibhav wrote:
quoted

On 12/6/2012 1:38 PM, Manjunathappa, Prakash wrote:
quoted
Hi Tomi,

On Wed, Oct 31, 2012 at 10:52:59, Manjunathappa, Prakash wrote:
quoted
Hi,

On Wed, Oct 31, 2012 at 21:26:08, Pantelis Antoniou wrote:
quoted
This driver can be used for AM33xx devices, like the popular beaglebone.

Signed-off-by: Pantelis Antoniou <redacted>
---
 drivers/video/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/Kconfig b/drivers/video/Kconfig
index 9791d10..e7868d8 100644
--- a/drivers/video/Kconfig
+++ b/drivers/video/Kconfig
@@ -2202,7 +2202,7 @@ config FB_SH7760
 
 config FB_DA8XX
 	tristate "DA8xx/OMAP-L1xx Framebuffer support"
-	depends on FB && ARCH_DAVINCI_DA8XX
+	depends on FB && (ARCH_DAVINCI_DA8XX || SOC_AM33XX)
Agreed this is present on da8xx and am33xx, but moving forward for
supporting DT, we should be avoiding these dependencies. So instead
change this to remove machine dependencies.
I could be wrong here, having dependency on platform seems to be right.
Otherwise may lead to build errors for other platforms. 
No, it should not result in to build error unless driver uses some
platform specific api's.
Agreed, should not result in build error. But is it ok to show this option
on the platforms which do not have this IP?
You can choose to put machine dependency here, as this patch is already 
doing it. The side-effect of this would be, list may grow and you may have 
to edit this file everytime.


Thanks,
Vaibhav 

RE: [PATCH] da8xx: Allow use by am33xx based devices

From: Mohammed, Afzal <hidden>
Date: 2013-01-07 12:03:30

SGksDQoNCk9uIFdlZCwgRGVjIDEyLCAyMDEyIGF0IDEzOjMwOjU2LCBIaXJlbWF0aCwgVmFpYmhh
diB3cm90ZToNCj4gT24gV2VkLCBEZWMgMTIsIDIwMTIgYXQgMTI6NTA6MjgsIE1hbmp1bmF0aGFw
cGEsIFByYWthc2ggd3JvdGU6DQoNCj4gPiBBZ3JlZWQsIHNob3VsZCBub3QgcmVzdWx0IGluIGJ1
aWxkIGVycm9yLiBCdXQgaXMgaXQgb2sgdG8gc2hvdyB0aGlzIG9wdGlvbg0KPiA+IG9uIHRoZSBw
bGF0Zm9ybXMgd2hpY2ggZG8gbm90IGhhdmUgdGhpcyBJUD8NCj4gPiANCj4gDQo+IFlvdSBjYW4g
Y2hvb3NlIHRvIHB1dCBtYWNoaW5lIGRlcGVuZGVuY3kgaGVyZSwgYXMgdGhpcyBwYXRjaCBpcyBh
bHJlYWR5IA0KPiBkb2luZyBpdC4gVGhlIHNpZGUtZWZmZWN0IG9mIHRoaXMgd291bGQgYmUsIGxp
c3QgbWF5IGdyb3cgYW5kIHlvdSBtYXkgaGF2ZSANCj4gdG8gZWRpdCB0aGlzIGZpbGUgZXZlcnl0
aW1lLg0KDQpJdCBzZWVtcyBhZGRpbmcgbWFjaGluZSBkZXBlbmRlbmN5IGlzIG1vcmUgaW4gbGlu
ZSB3aXRoIHRoZQ0KYXBwcm9hY2ggYWRvcHRlZCBpbiBzaW1pbGFyIGNhc2VzLiBBcyB0aGlzIElQ
IGlzIHVzZWQgb25seQ0KaW4gMiBhcmNoJ3MgYW5kIHdvdWxkIG5vdCBpbiBhbnkgaW1tZWRpYXRl
IGZ1dHVyZSBnbyB3aXRoDQpvdGhlciBhcmNoJ3MsIGl0IHdvdWxkIGJlIGJldHRlciBub3QgdG8g
YXNrIG90aGVyIGFyY2gncyBhDQpxdWVzdGlvbiBvbiB3aGV0aGVyIHRoaXMgZHJpdmVyIG5lZWRz
IHRvIGJlIHNlbGVjdGVkIG9yIG5vdC4NCg0KUmVnYXJkcw0KQWZ6YWwNCg=
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help