[PATCH] OMAPDSS: Correct check for the callback pointer in dss_dsi_disable_pads()

Subsystems: framebuffer layer, the rest

STALE5040d

2 messages, 2 authors, 2012-10-16 · open the first message on its own page

[PATCH] OMAPDSS: Correct check for the callback pointer in dss_dsi_disable_pads()

From: Peter Ujfalusi <hidden>
Date: 2012-10-16 11:51:29

Appear to be a copy-paste bug: the code was checking board_data->dsi_enable_pads
while calling board_data->dsi_disable_pads.


Signed-off-by: Peter Ujfalusi <redacted>
---

Hi Tomi,

not sure if this need to be included to 3.7

Regards,
Peter

 drivers/video/omap2/dss/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/video/omap2/dss/core.c b/drivers/video/omap2/dss/core.c
index b2af72d..7afaf61 100644
--- a/drivers/video/omap2/dss/core.c
+++ b/drivers/video/omap2/dss/core.c
@@ -122,7 +122,7 @@ void dss_dsi_disable_pads(int dsi_id, unsigned lane_mask)
 {
 	struct omap_dss_board_info *board_data = core.pdev->dev.platform_data;
 
-	if (!board_data->dsi_enable_pads)
+	if (!board_data->dsi_disable_pads)
 		return;
 
 	return board_data->dsi_disable_pads(dsi_id, lane_mask);
-- 
1.7.12.3

Re: [PATCH] OMAPDSS: Correct check for the callback pointer in dss_dsi_disable_pads()

From: Tomi Valkeinen <hidden>
Date: 2012-10-16 13:31:35

On 2012-10-16 14:51, Peter Ujfalusi wrote:
Appear to be a copy-paste bug: the code was checking board_data->dsi_enable_pads
while calling board_data->dsi_disable_pads.


Signed-off-by: Peter Ujfalusi <redacted>
---

Hi Tomi,

not sure if this need to be included to 3.7
Thanks. Probably not needed for 3.7, as we never hit that bug with the
current kernel: if dsi_enable_pads is defined we also always define
dsi_disable_pads.

 Tomi

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help