# \[PATCH v2 0/8\] ARM: mostly harmless gcc warnings - Subsystems: FRAMEBUFFER LAYER, ARM/CLKDEV SUPPORT, ARM/RISCPC ARCHITECTURE, ARM/SAMSUNG S3C, S5P AND EXYNOS ARM ARCHITECTURES, MEMORY MANAGEMENT, PCMCIA SUBSYSTEM, PXA2xx/PXA3xx SUPPORT, SAMSUNG SPI DRIVERS, SCSI SUBSYSTEM, SPI SUBSYSTEM, THE REST, USB EHCI DRIVER, USB SUBSYSTEM - Maintainers: Helge Deller, Russell King, Krzysztof Kozlowski, Peter Griffin, Andrew Morton, Dominik Brodowski, Daniel Mack, Haojian Zhuang, Robert Jarzmik, Andi Shyti, "James E.J. Bottomley", "Martin K. Petersen", Mark Brown, Linus Torvalds, Alan Stern, Greg Kroah-Hartman - Series: 8 patches touching 8 files, +10/-9 - Status: PENDING ยท 2 of 8 reviewed - Pending, 2 of 8 reviewed. - Revision v2 (2 revisions archived). - List: linux-fbdev - 4 messages, 3 authors - Page: https://ratatoskr.run/linux-fbdev/2012/10/3936815/t ## \[PATCH v2 0/8\] ARM: mostly harmless gcc warnings - From: Arnd Bergmann \ - Date: 2012-10-09 20:15:10 - Message: https://ratatoskr.run/linux-fbdev/2012/10/3936815.md ```text Most patches from the first time this was posted have been adopted by a subsystem maintainer or were show to be obsolete. Here are the remaining ones again. I'm planning to submit those patches that are still necessary by the time we have an -rc1 through the arm-soc tree, but my preference is still to have them go through the subsystem maintainers. Olof: should we add it to for-next? Arnd Arnd Bergmann (8): SCSI: ARM: ncr5380/oak uses no interrupts SCSI: ARM: make fas216_dumpinfo function conditional mm/slob: use min_t() to compare ARCH_SLAB_MINALIGN USB: EHCI: mark ehci_orion_conf_mbus_windows __devinit clk: don't mark clkdev_add_table as init pcmcia: sharpsl: don't discard sharpsl_pcmcia_ops video: mark nuc900fb_map_video_memory as __devinit spi/s3c64xx: use correct dma_transfer_direction type drivers/clk/clkdev.c | 2 +- drivers/pcmcia/pxa2xx_sharpsl.c | 2 +- drivers/scsi/arm/fas216.c | 2 +- drivers/scsi/arm/oak.c | 1 + drivers/spi/spi-s3c64xx.c | 2 +- drivers/usb/host/ehci-orion.c | 2 +- drivers/video/nuc900fb.c | 2 +- mm/slob.c | 6 +++--- 8 files changed, 10 insertions(+), 9 deletions(-) -- 1.7.10 Cc: "James E.J. Bottomley" Cc: Ben Dooks Cc: Dominik Brodowski Cc: Florian Tobias Schandinat Cc: Grant Likely Cc: Greg Kroah-Hartman Cc: Jochen Friedrich Cc: Kukjin Kim Cc: Mike Turquette Cc: Pavel Machek Cc: Pekka Enberg Cc: Russell King Cc: Wan ZongShun Cc: Cc: Cc: Cc: Cc: Cc: Cc: Cc: ``` ## \[PATCH v2 7/8\] video: mark nuc900fb\_map\_video\_memory as \_\_devinit - From: Arnd Bergmann \ - Date: 2012-10-09 20:14:24 - Message: https://ratatoskr.run/linux-fbdev/2012/10/3936811.md ```text nuc900fb_map_video_memory is called by an devinit function that may be called at run-time, but the function itself is marked __init and will be discarded after boot. To avoid calling into a function that may have been overwritten, mark nuc900fb_map_video_memory itself as __devinit. Without this patch, building nuc950_defconfig results in: WARNING: drivers/video/built-in.o(.devinit.text+0x26c): Section mismatch in reference from the function nuc900fb_probe() to the function .init.text:nuc900fb_map_video_memory() The function __devinit nuc900fb_probe() references a function __init nuc900fb_map_video_memory(). If nuc900fb_map_video_memory is only used by nuc900fb_probe then annotate nuc900fb_map_video_memory with a matching annotation. Signed-off-by: Arnd Bergmann Cc: Wan ZongShun Cc: Florian Tobias Schandinat Cc: --- drivers/video/nuc900fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/nuc900fb.c b/drivers/video/nuc900fb.c index e10f551..b31b12b 100644 --- a/drivers/video/nuc900fb.c +++ b/drivers/video/nuc900fb.c @@ -387,7 +387,7 @@ static int nuc900fb_init_registers(struct fb_info *info) * The buffer should be a non-cached, non-buffered, memory region * to allow palette and pixel writes without flushing the cache. */ -static int __init nuc900fb_map_video_memory(struct fb_info *info) +static int __devinit nuc900fb_map_video_memory(struct fb_info *info) { struct nuc900fb_info *fbi = info->par; dma_addr_t map_dma; -- 1.7.10 ``` ## Re: \[PATCH v2 7/8\] video: mark nuc900fb\_map\_video\_memory as \_\_devinit - From: Wan ZongShun \ - Date: 2012-10-10 01:41:51 - Message: https://ratatoskr.run/linux-fbdev/2012/10/3936936.md ```text 2012/10/10 Arnd Bergmann [ref]: > nuc900fb_map_video_memory is called by an devinit function > that may be called at run-time, but the function itself is > marked __init and will be discarded after boot. > > To avoid calling into a function that may have been overwritten, > mark nuc900fb_map_video_memory itself as __devinit. > > Without this patch, building nuc950_defconfig results in: > > WARNING: drivers/video/built-in.o(.devinit.text+0x26c): Section mismatch in reference from the function nuc900fb_probe() to the function .init.text:nuc900fb_map_video_memory() > The function __devinit nuc900fb_probe() references > a function __init nuc900fb_map_video_memory(). > If nuc900fb_map_video_memory is only used by nuc900fb_probe then > annotate nuc900fb_map_video_memory with a matching annotation. > > Signed-off-by: Arnd Bergmann > Cc: Wan ZongShun > Cc: Florian Tobias Schandinat > Cc: Thanks for your patch. Acked-by: Wan ZongShun > --- > drivers/video/nuc900fb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/nuc900fb.c b/drivers/video/nuc900fb.c > index e10f551..b31b12b 100644 > --- a/drivers/video/nuc900fb.c > +++ b/drivers/video/nuc900fb.c > @@ -387,7 +387,7 @@ static int nuc900fb_init_registers(struct fb_info *info) > * The buffer should be a non-cached, non-buffered, memory region > * to allow palette and pixel writes without flushing the cache. > */ > -static int __init nuc900fb_map_video_memory(struct fb_info *info) > +static int __devinit nuc900fb_map_video_memory(struct fb_info *info) > { > struct nuc900fb_info *fbi = info->par; > dma_addr_t map_dma; > -- > 1.7.10 > -- Wan ZongShun. www.mcuos.com ``` ## Re: \[PATCH v2 7/8\] video: mark nuc900fb\_map\_video\_memory as \_\_devinit - From: Florian Tobias Schandinat \ - Date: 2012-10-10 12:36:17 - Message: https://ratatoskr.run/linux-fbdev/2012/10/3937105.md ```text On 10/09/2012 08:13 PM, Arnd Bergmann wrote: > nuc900fb_map_video_memory is called by an devinit function > that may be called at run-time, but the function itself is > marked __init and will be discarded after boot. > > To avoid calling into a function that may have been overwritten, > mark nuc900fb_map_video_memory itself as __devinit. > > Without this patch, building nuc950_defconfig results in: > > WARNING: drivers/video/built-in.o(.devinit.text+0x26c): Section mismatch in reference from the function nuc900fb_probe() to the function .init.text:nuc900fb_map_video_memory() > The function __devinit nuc900fb_probe() references > a function __init nuc900fb_map_video_memory(). > If nuc900fb_map_video_memory is only used by nuc900fb_probe then > annotate nuc900fb_map_video_memory with a matching annotation. > > Signed-off-by: Arnd Bergmann > Cc: Wan ZongShun > Cc: Florian Tobias Schandinat > Cc: Applied. Thanks, Florian Tobias Schandinat > --- > drivers/video/nuc900fb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/nuc900fb.c b/drivers/video/nuc900fb.c > index e10f551..b31b12b 100644 > --- a/drivers/video/nuc900fb.c > +++ b/drivers/video/nuc900fb.c > @@ -387,7 +387,7 @@ static int nuc900fb_init_registers(struct fb_info *info) > * The buffer should be a non-cached, non-buffered, memory region > * to allow palette and pixel writes without flushing the cache. > */ > -static int __init nuc900fb_map_video_memory(struct fb_info *info) > +static int __devinit nuc900fb_map_video_memory(struct fb_info *info) > { > struct nuc900fb_info *fbi = info->par; > dma_addr_t map_dma; ```