# RE: \[PATCH 2/2\] video: exynos\_mipi\_dsi: Fix potential NULL pointer dereference

- From: Inki Dae \<inki.dae@samsung.com\>
- Date: 2012-09-19 02:28:40 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2012/09/13463866
- Thread: https://ratatoskr.run/linux-fbdev/2012/09/13463865/t.md

```text


> -----Original Message-----
> From: Sachin Kamat [mailto:<redacted>]
> Sent: Tuesday, September 18, 2012 8:38 PM
> To: <redacted>
> Cc: inki.dae@samsung.com; <redacted>; FlorianSchandinat@gmx.de;
> sachin.kamat@linaro.org; patches@linaro.org
> Subject: [PATCH 2/2] video: exynos_mipi_dsi: Fix potential NULL pointer
> dereference
> 
> The error message printed when dsim is NULL references its member.
> This will cause NULL pointer derefernce error. Hence change dev_err
> to pr_err to avoid it.
> 
> Signed-off-by: Sachin Kamat <redacted>
> ---
>  drivers/video/exynos/exynos_mipi_dsi_common.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/video/exynos/exynos_mipi_dsi_common.c
> b/drivers/video/exynos/exynos_mipi_dsi_common.c
> index 7cc4113..4fc64c4 100644
> --- a/drivers/video/exynos/exynos_mipi_dsi_common.c
> +++ b/drivers/video/exynos/exynos_mipi_dsi_common.c
> @@ -80,7 +80,7 @@ irqreturn_t exynos_mipi_dsi_interrupt_handler(int irq,
> void *dev_id)
>  	unsigned int intsrc, intmsk;
> 
>  	if (dsim = NULL) {
> -		dev_err(dsim->dev, "%s: wrong parameter\n", __func__);
> +		pr_err("%s: wrong parameter\n", __func__);
>  		return IRQ_NONE;
>  	}

Please, just remove above exception codes. dsim was allocated and already
checked by probe so this exception isn't needed.

Thanks,
Inki Dae


> 
> --
> 1.7.4.1

```