# Re: \[PATCH 1/6\] OMAPDSS: DISPC: cleanup cpu\_is\_xxxx checks

- From: Tomi Valkeinen \<hidden\>
- Date: 2012-08-14 09:58:58 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2012/08/13463609
- Thread: https://ratatoskr.run/linux-omap/2012/08/13463753/t.md

```text
On Mon, 2012-08-13 at 17:28 +0530, Chandrabhanu Mahapatra wrote:
> All the cpu_is checks have been moved to dispc_init_features function providing
> a much more generic and cleaner interface. The OMAP version and revision
> specific functions and data are initialized by dispc_features structure which is
> local to dispc.c.

The comments I gave for the dss.c patch apply to this one also, about
devm_free, __initdata, and the names of the feat arrays.

Otherwise, looks good.

 Tomi

```

## Attachments

- [signature.asc](https://ratatoskr.run/linux-fbdev/2012/08/13463609/attachment/0) (application/pgp-signature, 836 bytes)