[PATCH 06/10] video: exynos_dp: Fix get_pll_lock_status return value

Subsystems: framebuffer layer, the rest

STALE5155d REVIEWED: 1 (0M)

1 review trailer.

3 messages, 3 authors, 2012-08-23 · open the first message on its own page

[PATCH 06/10] video: exynos_dp: Fix get_pll_lock_status return value

From: Sean Paul <hidden>
Date: 2012-08-08 03:54:20 

Fix the return value of exynos_dp_get_pll_lock_status to
reflect what it actually returns.

Signed-off-by: Sean Paul <redacted>
Reviewed-by: Olof Johansson <redacted>
---
 drivers/video/exynos/exynos_dp_core.h |    2 +-
 drivers/video/exynos/exynos_dp_reg.c  |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/exynos/exynos_dp_core.h b/drivers/video/exynos/exynos_dp_core.h
index 8526e54..6431c65 100644
--- a/drivers/video/exynos/exynos_dp_core.h
+++ b/drivers/video/exynos/exynos_dp_core.h
@@ -43,7 +43,7 @@ void exynos_dp_init_interrupt(struct exynos_dp_device *dp);
 void exynos_dp_reset(struct exynos_dp_device *dp);
 void exynos_dp_swreset(struct exynos_dp_device *dp);
 void exynos_dp_config_interrupt(struct exynos_dp_device *dp);
-u32 exynos_dp_get_pll_lock_status(struct exynos_dp_device *dp);
+enum pll_status exynos_dp_get_pll_lock_status(struct exynos_dp_device *dp);
 void exynos_dp_set_pll_power_down(struct exynos_dp_device *dp, bool enable);
 void exynos_dp_set_analog_power_down(struct exynos_dp_device *dp,
 				enum analog_power_block block,
diff --git a/drivers/video/exynos/exynos_dp_reg.c b/drivers/video/exynos/exynos_dp_reg.c
index a121bed..d7b1494 100644
--- a/drivers/video/exynos/exynos_dp_reg.c
+++ b/drivers/video/exynos/exynos_dp_reg.c
@@ -179,7 +179,7 @@ void exynos_dp_config_interrupt(struct exynos_dp_device *dp)
 	writel(reg, dp->reg_base + EXYNOS_DP_INT_STA_MASK);
 }
 
-u32 exynos_dp_get_pll_lock_status(struct exynos_dp_device *dp)
+enum pll_status exynos_dp_get_pll_lock_status(struct exynos_dp_device *dp)
 {
 	u32 reg;
 
-- 
1.7.7.3

Re: [PATCH 06/10] video: exynos_dp: Fix get_pll_lock_status return value

From: Jingoo Han <hidden>
Date: 2012-08-20 09:20:36 

On Wednesday, August 08, 2012 12:54 PM Sean Paul wrote:
Fix the return value of exynos_dp_get_pll_lock_status to
reflect what it actually returns.

Signed-off-by: Sean Paul <redacted>
Reviewed-by: Olof Johansson <redacted>

Acked-by: Jingoo Han <redacted>
quoted hunk
---
 drivers/video/exynos/exynos_dp_core.h |    2 +-
 drivers/video/exynos/exynos_dp_reg.c  |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/exynos/exynos_dp_core.h b/drivers/video/exynos/exynos_dp_core.h
index 8526e54..6431c65 100644
--- a/drivers/video/exynos/exynos_dp_core.h
+++ b/drivers/video/exynos/exynos_dp_core.h
@@ -43,7 +43,7 @@ void exynos_dp_init_interrupt(struct exynos_dp_device *dp);
 void exynos_dp_reset(struct exynos_dp_device *dp);
 void exynos_dp_swreset(struct exynos_dp_device *dp);
 void exynos_dp_config_interrupt(struct exynos_dp_device *dp);
-u32 exynos_dp_get_pll_lock_status(struct exynos_dp_device *dp);
+enum pll_status exynos_dp_get_pll_lock_status(struct exynos_dp_device *dp);
 void exynos_dp_set_pll_power_down(struct exynos_dp_device *dp, bool enable);
 void exynos_dp_set_analog_power_down(struct exynos_dp_device *dp,
 				enum analog_power_block block,
diff --git a/drivers/video/exynos/exynos_dp_reg.c b/drivers/video/exynos/exynos_dp_reg.c
index a121bed..d7b1494 100644
--- a/drivers/video/exynos/exynos_dp_reg.c
+++ b/drivers/video/exynos/exynos_dp_reg.c
@@ -179,7 +179,7 @@ void exynos_dp_config_interrupt(struct exynos_dp_device *dp)
 	writel(reg, dp->reg_base + EXYNOS_DP_INT_STA_MASK);
 }

-u32 exynos_dp_get_pll_lock_status(struct exynos_dp_device *dp)
+enum pll_status exynos_dp_get_pll_lock_status(struct exynos_dp_device *dp)
 {
 	u32 reg;

--
1.7.7.3





  

    
Re: [PATCH 06/10] video: exynos_dp: Fix get_pll_lock_status return value

    

      From: Florian Tobias Schandinat <FlorianSchandinat@gmx.de>

      Date: 2012-08-23 20:49:18 
    

  

  
On 08/20/2012 09:20 AM, Jingoo Han wrote:
On Wednesday, August 08, 2012 12:54 PM Sean Paul wrote:
quoted
Fix the return value of exynos_dp_get_pll_lock_status to
reflect what it actually returns.

Signed-off-by: Sean Paul <redacted>
Reviewed-by: Olof Johansson <redacted>

Acked-by: Jingoo Han <redacted>
Applied.


Thanks,

Florian Tobias Schandinat

quoted
---
 drivers/video/exynos/exynos_dp_core.h |    2 +-
 drivers/video/exynos/exynos_dp_reg.c  |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/video/exynos/exynos_dp_core.h b/drivers/video/exynos/exynos_dp_core.h
index 8526e54..6431c65 100644
--- a/drivers/video/exynos/exynos_dp_core.h
+++ b/drivers/video/exynos/exynos_dp_core.h
@@ -43,7 +43,7 @@ void exynos_dp_init_interrupt(struct exynos_dp_device *dp);
 void exynos_dp_reset(struct exynos_dp_device *dp);
 void exynos_dp_swreset(struct exynos_dp_device *dp);
 void exynos_dp_config_interrupt(struct exynos_dp_device *dp);
-u32 exynos_dp_get_pll_lock_status(struct exynos_dp_device *dp);
+enum pll_status exynos_dp_get_pll_lock_status(struct exynos_dp_device *dp);
 void exynos_dp_set_pll_power_down(struct exynos_dp_device *dp, bool enable);
 void exynos_dp_set_analog_power_down(struct exynos_dp_device *dp,
 				enum analog_power_block block,
diff --git a/drivers/video/exynos/exynos_dp_reg.c b/drivers/video/exynos/exynos_dp_reg.c
index a121bed..d7b1494 100644
--- a/drivers/video/exynos/exynos_dp_reg.c
+++ b/drivers/video/exynos/exynos_dp_reg.c
@@ -179,7 +179,7 @@ void exynos_dp_config_interrupt(struct exynos_dp_device *dp)
 	writel(reg, dp->reg_base + EXYNOS_DP_INT_STA_MASK);
 }

-u32 exynos_dp_get_pll_lock_status(struct exynos_dp_device *dp)
+enum pll_status exynos_dp_get_pll_lock_status(struct exynos_dp_device *dp)
 {
 	u32 reg;

--
1.7.7.3




    
  

  
    

      

        Keyboard shortcuts
      

      

        
          
hback out one level

          
jnext message in thread

          
kprevious message in thread

          
ldrill in

          
Escclose help / fold thread tree

          
?toggle this help