[PATCH] OMAPDSS: DISPC: Use msleep instead of blocking mdelay

Subsystems: framebuffer layer, the rest

STALE5188d

2 messages, 2 authors, 2012-07-31 · open the first message on its own page

[PATCH] OMAPDSS: DISPC: Use msleep instead of blocking mdelay

From: Jassi Brar <hidden>
Date: 2012-07-24 14:15:55

We have no reason to block in the error handler workqueue, so use msleep.

Signed-off-by: Jassi Brar <redacted>
---
 drivers/video/omap2/dss/dispc.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/omap2/dss/dispc.c b/drivers/video/omap2/dss/dispc.c
index c56a51a..0e3ad44 100644
--- a/drivers/video/omap2/dss/dispc.c
+++ b/drivers/video/omap2/dss/dispc.c
@@ -3492,7 +3492,7 @@ static void dispc_error_worker(struct work_struct *work)
 					ovl->name);
 			dispc_ovl_enable(ovl->id, false);
 			dispc_mgr_go(ovl->manager->id);
-			mdelay(50);
+			msleep(50);
 		}
 	}
 
@@ -3524,7 +3524,7 @@ static void dispc_error_worker(struct work_struct *work)
 			}
 
 			dispc_mgr_go(mgr->id);
-			mdelay(50);
+			msleep(50);
 
 			if (enable)
 				dssdev->driver->enable(dssdev);
-- 
1.7.4.1

Re: [PATCH] OMAPDSS: DISPC: Use msleep instead of blocking mdelay

From: Tomi Valkeinen <hidden>
Date: 2012-07-31 08:53:28

On Tue, 2012-07-24 at 19:33 +0530, Jassi Brar wrote:
We have no reason to block in the error handler workqueue, so use msleep.

Signed-off-by: Jassi Brar <redacted>
---
 drivers/video/omap2/dss/dispc.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)
Thanks, applied.

As a side note, I hate that error handler =). It was a quick emergency
hack to somehow handle certain situations, but generally it sucks.
However, I don't really have a good idea what to do in case we get
errors from DSS HW.

 Tomi
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help