# Re: \[PATCH 1/2\] video: msm: Fix section mismatches in mddi.c

- From: Florian Tobias Schandinat \<FlorianSchandinat@gmx.de\>
- Date: 2012-04-23 06:17:05 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2012/04/3853498
- Thread: https://ratatoskr.run/linux-arm-msm/2012/04/3848864/t.md

```text
On 04/12/2012 06:45 PM, David Brown wrote:
> The change
>     commit 461cbe77d0a4f887c33a3a95ea68a7daf23b4302
>     Author: Gregory Bean [ref]
>     Date:   Wed Jul 28 10:22:13 2010 -0700
> 
>         video: msm: Fix section mismatch in mddi.c.
> 
> fixes a section mismatch between the board file and the driver's probe
> function, however, it misses the additional mismatches between the
> probe function and some routines it calls.  Fix these up as well.
> 
> Signed-off-by: David Brown <redacted>

Applied.


Thanks,

Florian Tobias Schandinat

> ---
>  drivers/video/msm/mddi.c |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/video/msm/mddi.c b/drivers/video/msm/mddi.c
> index 4527cbf..b061d70 100644
> --- a/drivers/video/msm/mddi.c
> +++ b/drivers/video/msm/mddi.c
> @@ -420,7 +420,7 @@ static void mddi_resume(struct msm_mddi_client_data *cdata)
>  	mddi_set_auto_hibernate(&mddi->client_data, 1);
>  }
>  
> -static int __init mddi_get_client_caps(struct mddi_info *mddi)
> +static int __devinit mddi_get_client_caps(struct mddi_info *mddi)
>  {
>  	int i, j;
>  
> @@ -622,9 +622,9 @@ uint32_t mddi_remote_read(struct msm_mddi_client_data *cdata, uint32_t reg)
>  
>  static struct mddi_info mddi_info[2];
>  
> -static int __init mddi_clk_setup(struct platform_device *pdev,
> -				 struct mddi_info *mddi,
> -				 unsigned long clk_rate)
> +static int __devinit mddi_clk_setup(struct platform_device *pdev,
> +				    struct mddi_info *mddi,
> +				    unsigned long clk_rate)
>  {
>  	int ret;
>  

```
