[PATCH] gma500: Fix mmap frambuffer

Subsystems: drm drivers, drm drivers and misc gpu patches, drm drivers for gma500 (poulsbo, moorestown and derivative chipsets), the rest

STALE5262d

2 messages, 2 authors, 2012-03-15 · open the first message on its own page

[PATCH] gma500: Fix mmap frambuffer

From: Yoichi Yuasa <hidden>
Date: 2012-03-15 12:28:31

It cannot map correctly if page fault begins from a intermediate address.

Signed-off-by: Yoichi Yuasa <redacted>
---
 drivers/gpu/drm/gma500/framebuffer.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/gma500/framebuffer.c b/drivers/gpu/drm/gma500/framebuffer.c
index be61673..5154493 100644
--- a/drivers/gpu/drm/gma500/framebuffer.c
+++ b/drivers/gpu/drm/gma500/framebuffer.c
@@ -158,7 +158,7 @@ static int psbfb_vm_fault(struct vm_area_struct *vma, struct vm_fault *vmf)
 	unsigned long phys_addr = (unsigned long)dev_priv->stolen_base;
 
 	page_num = (vma->vm_end - vma->vm_start) >> PAGE_SHIFT;
-	address = (unsigned long)vmf->virtual_address;
+	address = (unsigned long)vmf->virtual_address - (vmf->pgoff << PAGE_SHIFT);
 
 	vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
 
-- 
1.7.0.4

Re: [PATCH] gma500: Fix mmap frambuffer

From: Alan Cox <hidden>
Date: 2012-03-15 14:33:07

On Thu, 15 Mar 2012 21:28:16 +0900
Yoichi Yuasa [off-list ref] wrote:
It cannot map correctly if page fault begins from a intermediate
address.
Thanks, that explains one very strange bug I've been seeing !
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help