# Re: \[PATCH\] Video : Amba: Use in\_interrupt() in clcdfb\_sleep().

- From: Russell King - ARM Linux \<hidden\>
- Date: 2012-03-11 13:28:00 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2012/03/3833824
- Thread: https://ratatoskr.run/linux-fbdev/2012/03/3833822/t.md

```text
On Sun, Mar 11, 2012 at 06:44:25PM +0530, santosh nayak wrote:
> From: Santosh Nayak <redacted>
> 
> Instead of "in_atomic()", we can use in_interrupt() to check whether
> its an interrupt context.

What are you trying to fix?

Your description is an example of a bad commit comment.  It merely
describes the change, which anyone can see by looking at the diff.
What it totally and utterly fails to do is to describe _why_ the
change is necessary or what the problem is.

So, until it does, this patch gets a definite NAK.
```