# \[PATCH\] fb: exynos: Fix MIPI/DSI front/back porch settings - Subsystems: FRAMEBUFFER LAYER, THE REST - Maintainers: Helge Deller, Linus Torvalds - List: linux-fbdev - 2 messages, 2 authors - Page: https://ratatoskr.run/linux-fbdev/2012/03/13462833/t ## \[PATCH\] fb: exynos: Fix MIPI/DSI front/back porch settings - From: Laurent Pinchart \ - Date: 2012-03-08 15:35:54 - Message: https://ratatoskr.run/linux-fbdev/2012/03/13462833.md ```text The exynos_mipi_dsi_set_main_disp_[hv]porch() functions take front and back porch arguments in that order. This maps to the fb_videomode right/lower_margin and left/upper_margin respectively. Fix the caller accordingly. Signed-off-by: Laurent Pinchart --- drivers/video/exynos/exynos_mipi_dsi_common.c | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/video/exynos/exynos_mipi_dsi_common.c b/drivers/video/exynos/exynos_mipi_dsi_common.c index 14909c1..99f6451 100644 --- a/drivers/video/exynos/exynos_mipi_dsi_common.c +++ b/drivers/video/exynos/exynos_mipi_dsi_common.c @@ -738,11 +738,11 @@ int exynos_mipi_dsi_set_display_mode(struct mipi_dsim_device *dsim, if (dsim_config->auto_vertical_cnt = 0) { exynos_mipi_dsi_set_main_disp_vporch(dsim, dsim_config->cmd_allow, - timing->upper_margin, - timing->lower_margin); + timing->lower_margin, + timing->upper_margin); exynos_mipi_dsi_set_main_disp_hporch(dsim, - timing->left_margin, - timing->right_margin); + timing->right_margin, + timing->left_margin); exynos_mipi_dsi_set_main_disp_sync_area(dsim, timing->vsync_len, timing->hsync_len); -- Regards, Laurent Pinchart ``` ## Re: \[PATCH\] fb: exynos: Fix MIPI/DSI front/back porch settings - From: Donghwa Lee \ - Date: 2012-03-09 00:07:02 - Message: https://ratatoskr.run/linux-fbdev/2012/03/13462834.md ```text Hi, Laurent, On Fri, Mar 9, 2012 at 00:35 AM, Laurent Pinchart wrote: > The exynos_mipi_dsi_set_main_disp_[hv]porch() functions take front and > back porch arguments in that order. This maps to the fb_videomode > right/lower_margin and left/upper_margin respectively. Fix the caller > accordingly. > > Signed-off-by: Laurent Pinchart > --- > drivers/video/exynos/exynos_mipi_dsi_common.c | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) > It looks good to me. Acked-by: Donghwa Lee > diff --git a/drivers/video/exynos/exynos_mipi_dsi_common.c b/drivers/video/exynos/exynos_mipi_dsi_common.c > index 14909c1..99f6451 100644 > --- a/drivers/video/exynos/exynos_mipi_dsi_common.c > +++ b/drivers/video/exynos/exynos_mipi_dsi_common.c > @@ -738,11 +738,11 @@ int exynos_mipi_dsi_set_display_mode(struct mipi_dsim_device *dsim, > if (dsim_config->auto_vertical_cnt = 0) { > exynos_mipi_dsi_set_main_disp_vporch(dsim, > dsim_config->cmd_allow, > - timing->upper_margin, > - timing->lower_margin); > + timing->lower_margin, > + timing->upper_margin); > exynos_mipi_dsi_set_main_disp_hporch(dsim, > - timing->left_margin, > - timing->right_margin); > + timing->right_margin, > + timing->left_margin); > exynos_mipi_dsi_set_main_disp_sync_area(dsim, > timing->vsync_len, > timing->hsync_len); ```