# \[GIT PULL\] udlfb patches for fbdev-next

- List: linux-fbdev
- 4 messages, 3 authors
- Page: https://ratatoskr.run/linux-fbdev/2012/03/13462755/t

## \[GIT PULL\] udlfb patches for fbdev-next

- From: Bernie Thompson \<bernie@plugable.com\>
- Date: 2012-03-05 02:33:10 
- Message: https://ratatoskr.run/linux-fbdev/2012/03/13462755.md

```text
Hi Florian,

These are udlfb patches for fbdev-next (assume 3.4; compatible with 3.3)

Testing use of github to try to make patch submission easier.  1st
time. Be kind.
Not yet on git 1.7.9 for signed requests. Happy to send github pull requests.

All 5 patches are independent of each other.   Feedback welcome.

The following changes since commit 327e27681c27d3ed5ea470ec483904d1a318cb7f:

  video: s3c-fb: use devm_request_irq() (2012-02-24 00:50:07 +0000)

are available in the git repository at:
  git@github.com:bernieplug/linux-2.6.git fbdev-next

Ben Collins (2):
      udlfb: Make sure to get correct endian keys from vendor descriptor
      udlfb: Add module_param to allow forcing pixel_limit

Bernie Thompson (2):
      udlfb: add maintainer
      udlfb: fix hcd_buffer_free panic on unplug/replug

Martin Decky (1):
      udlfb: Improve debugging printouts with refresh rate

 MAINTAINERS           |    9 +++
 drivers/video/udlfb.c |  163 ++++++++++++++++++++++++++++--------------------
 include/video/udlfb.h |    1 +
 3 files changed, 105 insertions(+), 68 deletions(-)
```

## Re: \[GIT PULL\] udlfb patches for fbdev-next

- From: Florian Tobias Schandinat \<FlorianSchandinat@gmx.de\>
- Date: 2012-03-07 10:06:30 
- Message: https://ratatoskr.run/linux-fbdev/2012/03/13462756.md

```text
Hi Bernie,

On 03/05/2012 02:33 AM, Bernie Thompson wrote:
> Hi Florian,
> 
> These are udlfb patches for fbdev-next (assume 3.4; compatible with 3.3)
> 
> Testing use of github to try to make patch submission easier.  1st
> time. Be kind.
> Not yet on git 1.7.9 for signed requests. Happy to send github pull requests.

Merged.
For those few patches I don't consider signing crucial. It's still easy
enough to review, so it doesn't matter too much if github is compromised.

> All 5 patches are independent of each other.   Feedback welcome.

Looks good. Just "udlfb: fix hcd_buffer_free panic on unplug/replug"
wasn't trivial to review, hope it is well tested. I was wondering about
the patch of Olivier Sobrie as it was neither part of this pull-request
nor did you comment on it, but probably you read my comment I wrote when
I cc'ed you as you added yourself to MAINTAINERS.


Thanks,

Florian Tobias Schandinat

> 
> The following changes since commit 327e27681c27d3ed5ea470ec483904d1a318cb7f:
> 
>   video: s3c-fb: use devm_request_irq() (2012-02-24 00:50:07 +0000)
> 
> are available in the git repository at:
>   git@github.com:bernieplug/linux-2.6.git fbdev-next
> 
> Ben Collins (2):
>       udlfb: Make sure to get correct endian keys from vendor descriptor
>       udlfb: Add module_param to allow forcing pixel_limit
> 
> Bernie Thompson (2):
>       udlfb: add maintainer
>       udlfb: fix hcd_buffer_free panic on unplug/replug
> 
> Martin Decky (1):
>       udlfb: Improve debugging printouts with refresh rate
> 
>  MAINTAINERS           |    9 +++
>  drivers/video/udlfb.c |  163 ++++++++++++++++++++++++++++--------------------
>  include/video/udlfb.h |    1 +
>  3 files changed, 105 insertions(+), 68 deletions(-)
> 

```

## Re: \[GIT PULL\] udlfb patches for fbdev-next

- From: Bernie Thompson \<bernie@plugable.com\>
- Date: 2012-03-07 18:39:30 
- Message: https://ratatoskr.run/linux-fbdev/2012/03/13462757.md

```text
Hi Florian,

On Wed, Mar 7, 2012 at 2:06 AM, Florian Tobias Schandinat
[ref] wrote:
> Merged.

Thanks so much for doing that review/merge work.

> I was wondering about
> the patch of Olivier Sobrie as it was neither part of this pull-request
> nor did you comment on it, but probably you read my comment I wrote when
> I cc'ed you as you added yourself to MAINTAINERS.

That patch looks good. I didn't include it only because I hadn't
tested it.  Note that Jingoo's recommendation might run afoul of
checkpatch.pl (but Olivier's 2nd version worked around that anyway, so
it's fine - I'd recommend you take it).

Thanks for your work maintaining fbdev.  Best wishes,
Bernie
```

## RE: \[GIT PULL\] udlfb patches for fbdev-next

- From: Jingoo Han \<hidden\>
- Date: 2012-03-08 00:12:49 
- Message: https://ratatoskr.run/linux-fbdev/2012/03/13462758.md

```text
> -----Original Message-----
> From: <redacted> [mailto:<redacted>] On Behalf Of Bernie
> Thompson
> Sent: Thursday, March 08, 2012 3:40 AM
> To: Florian Tobias Schandinat
> Cc: Linux Fbdev development list
> Subject: Re: [GIT PULL] udlfb patches for fbdev-next
> 
> Hi Florian,
> 
> On Wed, Mar 7, 2012 at 2:06 AM, Florian Tobias Schandinat
> [ref] wrote:
> > Merged.
> 
> Thanks so much for doing that review/merge work.
> 
> > I was wondering about
> > the patch of Olivier Sobrie as it was neither part of this pull-request
> > nor did you comment on it, but probably you read my comment I wrote when
> > I cc'ed you as you added yourself to MAINTAINERS.
> 
> That patch looks good. I didn't include it only because I hadn't
> tested it.  Note that Jingoo's recommendation might run afoul of
> checkpatch.pl (but Olivier's 2nd version worked around that anyway, so
> it's fine - I'd recommend you take it).

Yes, you are right.
Also, Oliver's 2nd version patch looks good.
Good luck.

Best regards,
Jingoo Han

> 
> Thanks for your work maintaining fbdev.  Best wishes,
> Bernie
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fbdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

```
