# Re: \[PATCH 3/3\] OMAPDSS: use sync versions of pm\_runtime\_put

- From: Kevin Hilman \<hidden\>
- Date: 2012-01-23 22:33:51 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2012/01/13462572
- Thread: https://ratatoskr.run/linux-omap/2012/01/13462551/t.md

```text
Tomi Valkeinen [ref] writes:

> omapdss doesn't work properly on system suspend. The problem seems to be
> the fact that omapdss uses pm_runtime_put() functions when turning off
> the hardware, and when system suspend is in process only sync versions
> are allowed.
>
> Using non-sync versions normally and sync versions when suspending would
> need rather ugly hacks to convey the information of
> suspending/not-suspending to different functions. Optimally the driver
> wouldn't even need to care about this, and the PM layer would handle
> syncing when suspend is in process.
>
> This patch changes all omapdss's pm_runtime_put calls to
> pm_runtime_put_sync. This fixes the suspend problem, and probably the
> performance penalty of always using sync versions is negligible.
>
> Signed-off-by: Tomi Valkeinen <redacted>

Acked-by: Kevin Hilman <redacted>
```