[patch] intelfb: remove some dead code

Subsystems: framebuffer layer, the rest

STALE5309d

2 messages, 1 author, 2012-01-27 · open the first message on its own page

[patch] intelfb: remove some dead code

From: Dan Carpenter <hidden>
Date: 2012-01-27 12:45:36

The goto on the line before means the return is unreachable.  The goto
also returns -ENOMEM so no changes are needed there.

Signed-off-by: Dan Carpenter <redacted>
diff --git a/drivers/video/intelfb/intelfbdrv.c b/drivers/video/intelfb/intelfbdrv.c
index c6afa33..02fd226 100644
--- a/drivers/video/intelfb/intelfbdrv.c
+++ b/drivers/video/intelfb/intelfbdrv.c
@@ -529,7 +529,6 @@ static int __devinit intelfb_pci_register(struct pci_dev *pdev,
 	if (fb_alloc_cmap(&info->cmap, 256, 1) < 0) {
 		ERR_MSG("Could not allocate cmap for intelfb_info.\n");
 		goto err_out_cmap;
-		return -ENODEV;
 	}
 
 	dinfo = info->par;

Re: [patch] intelfb: remove some dead code

From: Dan Carpenter <hidden>
Date: 2012-01-27 12:55:43

On Fri, Jan 27, 2012 at 03:45:36PM +0300, Dan Carpenter wrote:
The goto on the line before means the return is unreachable.  The goto
also returns -ENOMEM so no changes are needed there.
I meant ENODEV there.  Let me resend this.

regards,
dan carpenter
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help