# \[patch v2\] intelfb: remove some dead code

- Subsystems: FRAMEBUFFER LAYER, THE REST
- Maintainers: Helge Deller, Linus Torvalds
- List: linux-fbdev
- 2 messages, 2 authors
- Page: https://ratatoskr.run/linux-fbdev/2012/01/13149714/t

## \[patch v2\] intelfb: remove some dead code

- From: Dan Carpenter \<hidden\>
- Date: 2012-01-27 12:58:33 
- Message: https://ratatoskr.run/linux-fbdev/2012/01/13149714.md

```text
The goto on the line before means the return is unreachable.  The goto
also returns -ENODEV so no changes are needed there.

Signed-off-by: Dan Carpenter <redacted>
---
v2: fixed a typo in the commit message

diff --git a/drivers/video/intelfb/intelfbdrv.c b/drivers/video/intelfb/intelfbdrv.c
index c6afa33..02fd226 100644
--- a/drivers/video/intelfb/intelfbdrv.c
+++ b/drivers/video/intelfb/intelfbdrv.c
@@ -529,7 +529,6 @@ static int __devinit intelfb_pci_register(struct pci_dev *pdev,
 	if (fb_alloc_cmap(&info->cmap, 256, 1) < 0) {
 		ERR_MSG("Could not allocate cmap for intelfb_info.\n");
 		goto err_out_cmap;
-		return -ENODEV;
 	}
 
 	dinfo = info->par;

```

## Re: \[patch v2\] intelfb: remove some dead code

- From: Florian Tobias Schandinat \<FlorianSchandinat@gmx.de\>
- Date: 2012-01-30 05:25:04 
- Message: https://ratatoskr.run/linux-fbdev/2012/01/13149715.md

```text
On 01/27/2012 12:58 PM, Dan Carpenter wrote:
> The goto on the line before means the return is unreachable.  The goto
> also returns -ENODEV so no changes are needed there.
> 
> Signed-off-by: Dan Carpenter <redacted>

Applied.


Thanks,

Florian Tobias Schandinat

> ---
> v2: fixed a typo in the commit message
> 
> diff --git a/drivers/video/intelfb/intelfbdrv.c b/drivers/video/intelfb/intelfbdrv.c
> index c6afa33..02fd226 100644
> --- a/drivers/video/intelfb/intelfbdrv.c
> +++ b/drivers/video/intelfb/intelfbdrv.c
> @@ -529,7 +529,6 @@ static int __devinit intelfb_pci_register(struct pci_dev *pdev,
>  	if (fb_alloc_cmap(&info->cmap, 256, 1) < 0) {
>  		ERR_MSG("Could not allocate cmap for intelfb_info.\n");
>  		goto err_out_cmap;
> -		return -ENODEV;
>  	}
>  
>  	dinfo = info->par;
> 

```