# Re: \[PATCH RESEND\] MXSFB: Fix driver registration

- From: Florian Tobias Schandinat \<FlorianSchandinat@gmx.de\>
- Date: 2011-12-21 21:43:00 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2011/12/3802861
- Thread: https://ratatoskr.run/linux-fbdev/2011/12/3801597/t.md

```text
On 12/19/2011 03:37 PM, Marek Vasut wrote:
> The driver should be registered with mxsfb_driver, not with mxsfb_devtype.
> This caused obvious null pointer dereference and crash.
> 
> Signed-off-by: Marek Vasut <redacted>
> Cc: Wolfgang Denk <redacted>
> Cc: Stefano Babic <redacted>
> Cc: Shawn Guo <redacted>
> Cc: Huang Shijie <redacted>
> Cc: Axel Lin <redacted>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Acked-by: Axel Lin <redacted>
> Acked-by: Sascha Hauer <s.hauer@pengutronix.de>

Applied.


Thanks,

Florian Tobias Schandinat

> ---
>  drivers/video/mxsfb.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
> index 18742c2..d29c7c0 100644
> --- a/drivers/video/mxsfb.c
> +++ b/drivers/video/mxsfb.c
> @@ -902,7 +902,7 @@ static struct platform_driver mxsfb_driver = {
>  	},
>  };
>  
> -module_platform_driver(mxsfb_devtype);
> +module_platform_driver(mxsfb_driver);
>  
>  MODULE_DESCRIPTION("Freescale mxs framebuffer driver");
>  MODULE_AUTHOR("Sascha Hauer, Pengutronix");

```