# Re: \[PATCH\] MXSFB: Fix driver registration

- List: linux-fbdev
- 2 messages, 2 authors
- Page: https://ratatoskr.run/linux-fbdev/2011/12/3801547/t

## Re: \[PATCH\] MXSFB: Fix driver registration

- From: Shawn Guo \<hidden\>
- Date: 2011-12-19 13:51:27 
- Message: https://ratatoskr.run/linux-fbdev/2011/12/3801547.md

```text
Cc-ed Florian and linux-fbdev@vger.kernel.org, as I guess Florian is
the person who will take this patch.

-- Regards,Shawn
On 18 December 2011 08:58, Marek Vasut [ref] wrote:
> The driver should be registered with mxsfb_driver, not with mxsfb_devtype.
> This caused obvious null pointer dereference and crash.
>
> Signed-off-by: Marek Vasut <redacted>
> Cc: Wolfgang Denk <redacted>
> Cc: Stefano Babic <redacted>
> Cc: Shawn Guo <redacted>
> Cc: Huang Shijie <redacted>
> Cc: Axel Lin <redacted>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> ---
>  drivers/video/mxsfb.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
> index 18742c2..d29c7c0 100644
> --- a/drivers/video/mxsfb.c
> +++ b/drivers/video/mxsfb.c
> @@ -902,7 +902,7 @@ static struct platform_driver mxsfb_driver = {
>        },
>  };
>
> -module_platform_driver(mxsfb_devtype);
> +module_platform_driver(mxsfb_driver);
>
>  MODULE_DESCRIPTION("Freescale mxs framebuffer driver");
>  MODULE_AUTHOR("Sascha Hauer, Pengutronix");
> --
> 1.7.6.4
>
```

## Re: \[PATCH\] MXSFB: Fix driver registration

- From: Florian Tobias Schandinat \<FlorianSchandinat@gmx.de\>
- Date: 2011-12-19 15:18:18 
- Message: https://ratatoskr.run/linux-fbdev/2011/12/3801588.md

```text
Hi Marek,

can you please resend the patch to me and the fbdev mailing list, preferably
with all Ack's you received until now included.

On 12/19/2011 01:51 PM, Shawn Guo wrote:
> Cc-ed Florian and linux-fbdev@vger.kernel.org, as I guess Florian is
> the person who will take this patch.

Thanks, I will. I guess you wanted to Ack this patch?


Thanks,

Florian Tobias Schandinat

> 
> -- Regards,Shawn
> On 18 December 2011 08:58, Marek Vasut [ref] wrote:
>> The driver should be registered with mxsfb_driver, not with mxsfb_devtype.
>> This caused obvious null pointer dereference and crash.
>>
>> Signed-off-by: Marek Vasut <redacted>
>> Cc: Wolfgang Denk <redacted>
>> Cc: Stefano Babic <redacted>
>> Cc: Shawn Guo <redacted>
>> Cc: Huang Shijie <redacted>
>> Cc: Axel Lin <redacted>
>> Cc: Sascha Hauer <s.hauer@pengutronix.de>
>> ---
>>  drivers/video/mxsfb.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/video/mxsfb.c b/drivers/video/mxsfb.c
>> index 18742c2..d29c7c0 100644
>> --- a/drivers/video/mxsfb.c
>> +++ b/drivers/video/mxsfb.c
>> @@ -902,7 +902,7 @@ static struct platform_driver mxsfb_driver = {
>>        },
>>  };
>>
>> -module_platform_driver(mxsfb_devtype);
>> +module_platform_driver(mxsfb_driver);
>>
>>  MODULE_DESCRIPTION("Freescale mxs framebuffer driver");
>>  MODULE_AUTHOR("Sascha Hauer, Pengutronix");
>> --
>> 1.7.6.4
>>
> 

```