# \[PATCH\] video: s3c-fb: set missing bitmask of enabled hardware window

- Subsystems: FRAMEBUFFER LAYER, THE REST
- Maintainers: Helge Deller, Linus Torvalds
- List: linux-fbdev
- 2 messages, 2 authors
- Page: https://ratatoskr.run/linux-fbdev/2011/12/13462353/t

## \[PATCH\] video: s3c-fb: set missing bitmask of enabled hardware window

- From: Jingoo Han \<hidden\>
- Date: 2011-12-02 10:07:17 
- Message: https://ratatoskr.run/linux-fbdev/2011/12/13462353.md

```text
This patch set missing bitmask of enabled hardware window which
should be checked whenever the hardware window is enabled.

Signed-off-by: Jingoo Han <redacted>
---
 drivers/video/s3c-fb.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c
index 12eaee0..fc3df1d 100644
--- a/drivers/video/s3c-fb.c
+++ b/drivers/video/s3c-fb.c
@@ -574,6 +574,7 @@ static int s3c_fb_set_par(struct fb_info *info)
 	}
 
 	data = WINCONx_ENWIN;
+	sfb->enabled |= (1 << win->index);
 
 	/* note, since we have to round up the bits-per-pixel, we end up
 	 * relying on the bitfield information for r/g/b/a to work out
-- 
1.7.1

```

## Re: \[PATCH\] video: s3c-fb: set missing bitmask of enabled hardware

- From: Florian Tobias Schandinat \<FlorianSchandinat@gmx.de\>
- Date: 2011-12-19 23:10:29 
- Message: https://ratatoskr.run/linux-fbdev/2011/12/13462354.md

```text
On 12/02/2011 10:07 AM, Jingoo Han wrote:
> This patch set missing bitmask of enabled hardware window which
> should be checked whenever the hardware window is enabled.
> 
> Signed-off-by: Jingoo Han <redacted>

Applied.


Thanks,

Florian Tobias Schandinat

> ---
>  drivers/video/s3c-fb.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/video/s3c-fb.c b/drivers/video/s3c-fb.c
> index 12eaee0..fc3df1d 100644
> --- a/drivers/video/s3c-fb.c
> +++ b/drivers/video/s3c-fb.c
> @@ -574,6 +574,7 @@ static int s3c_fb_set_par(struct fb_info *info)
>  	}
>  
>  	data = WINCONx_ENWIN;
> +	sfb->enabled |= (1 << win->index);
>  
>  	/* note, since we have to round up the bits-per-pixel, we end up
>  	 * relying on the bitfield information for r/g/b/a to work out

```