# \[PATCH 09/11\] video: Remove redundant spi driver bus initialization - Subsystems: FRAMEBUFFER LAYER, THE REST - Maintainers: Helge Deller, Linus Torvalds - List: linux-fbdev - 3 messages, 3 authors - Page: https://ratatoskr.run/linux-fbdev/2011/11/3791515/t ## \[PATCH 09/11\] video: Remove redundant spi driver bus initialization - From: Lars-Peter Clausen \ - Date: 2011-11-24 15:28:49 - Message: https://ratatoskr.run/linux-fbdev/2011/11/3791515.md ```text In ancient times it was necessary to manually initialize the bus field of an spi_driver to spi_bus_type. These days this is done in spi_driver_register(), so we can drop the manual assignment. The patch was generated using the following coccinelle semantic patch: // @@ identifier _driver; @@ struct spi_driver _driver = { .driver = { - .bus = &spi_bus_type, }, }; // Signed-off-by: Lars-Peter Clausen Cc: Tomi Valkeinen Cc: Florian Tobias Schandinat Cc: Cc: --- drivers/video/omap/lcd_mipid.c | 1 - drivers/video/omap2/displays/panel-acx565akm.c | 1 - drivers/video/omap2/displays/panel-n8x0.c | 1 - .../omap2/displays/panel-nec-nl8048hl11-01b.c | 1 - .../video/omap2/displays/panel-tpo-td043mtea1.c | 1 - 5 files changed, 0 insertions(+), 5 deletions(-) diff --git a/drivers/video/omap/lcd_mipid.c b/drivers/video/omap/lcd_mipid.c index eb381db..8d546dd 100644 --- a/drivers/video/omap/lcd_mipid.c +++ b/drivers/video/omap/lcd_mipid.c @@ -603,7 +603,6 @@ static int mipid_spi_remove(struct spi_device *spi) static struct spi_driver mipid_spi_driver = { .driver = { .name = MIPID_MODULE_NAME, - .bus = &spi_bus_type, .owner = THIS_MODULE, }, .probe = mipid_spi_probe, diff --git a/drivers/video/omap2/displays/panel-acx565akm.c b/drivers/video/omap2/displays/panel-acx565akm.c index dbd59b8..51a87e1 100644 --- a/drivers/video/omap2/displays/panel-acx565akm.c +++ b/drivers/video/omap2/displays/panel-acx565akm.c @@ -803,7 +803,6 @@ static int acx565akm_spi_remove(struct spi_device *spi) static struct spi_driver acx565akm_spi_driver = { .driver = { .name = "acx565akm", - .bus = &spi_bus_type, .owner = THIS_MODULE, }, .probe = acx565akm_spi_probe, diff --git a/drivers/video/omap2/displays/panel-n8x0.c b/drivers/video/omap2/displays/panel-n8x0.c index 150e8ba..dc9408d 100644 --- a/drivers/video/omap2/displays/panel-n8x0.c +++ b/drivers/video/omap2/displays/panel-n8x0.c @@ -708,7 +708,6 @@ static int mipid_spi_remove(struct spi_device *spi) static struct spi_driver mipid_spi_driver = { .driver = { .name = "lcd_mipid", - .bus = &spi_bus_type, .owner = THIS_MODULE, }, .probe = mipid_spi_probe, diff --git a/drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c b/drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c index 2ba9d0c..8365e77 100644 --- a/drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c +++ b/drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c @@ -303,7 +303,6 @@ static struct spi_driver nec_8048_spi_driver = { .resume = nec_8048_spi_resume, .driver = { .name = "nec_8048_spi", - .bus = &spi_bus_type, .owner = THIS_MODULE, }, }; diff --git a/drivers/video/omap2/displays/panel-tpo-td043mtea1.c b/drivers/video/omap2/displays/panel-tpo-td043mtea1.c index 2462b9e..e6649aa 100644 --- a/drivers/video/omap2/displays/panel-tpo-td043mtea1.c +++ b/drivers/video/omap2/displays/panel-tpo-td043mtea1.c @@ -512,7 +512,6 @@ static int __devexit tpo_td043_spi_remove(struct spi_device *spi) static struct spi_driver tpo_td043_spi_driver = { .driver = { .name = "tpo_td043mtea1_panel_spi", - .bus = &spi_bus_type, .owner = THIS_MODULE, }, .probe = tpo_td043_spi_probe, -- 1.7.7.1 ``` ## Re: \[PATCH 09/11\] video: Remove redundant spi driver bus initialization - From: Tomi Valkeinen \ - Date: 2011-11-29 10:19:23 - Message: https://ratatoskr.run/linux-fbdev/2011/11/3793067.md ```text On Thu, 2011-11-24 at 16:29 +0100, Lars-Peter Clausen wrote: > In ancient times it was necessary to manually initialize the bus field of an > spi_driver to spi_bus_type. These days this is done in spi_driver_register(), > so we can drop the manual assignment. > > The patch was generated using the following coccinelle semantic patch: > // > @@ > identifier _driver; > @@ > struct spi_driver _driver = { > .driver = { > - .bus = &spi_bus_type, > }, > }; > // > > Signed-off-by: Lars-Peter Clausen > Cc: Tomi Valkeinen > Cc: Florian Tobias Schandinat > Cc: > Cc: Acked-by: Tomi Valkeinen Tomi ``` ## Re: \[PATCH 09/11\] video: Remove redundant spi driver bus initialization - From: Florian Tobias Schandinat \ - Date: 2011-12-04 00:36:53 - Message: https://ratatoskr.run/linux-fbdev/2011/12/3794994.md ```text On 11/24/2011 03:29 PM, Lars-Peter Clausen wrote: > In ancient times it was necessary to manually initialize the bus field of an > spi_driver to spi_bus_type. These days this is done in spi_driver_register(), > so we can drop the manual assignment. > > The patch was generated using the following coccinelle semantic patch: > // > @@ > identifier _driver; > @@ > struct spi_driver _driver = { > .driver = { > - .bus = &spi_bus_type, > }, > }; > // > > Signed-off-by: Lars-Peter Clausen > Cc: Tomi Valkeinen > Cc: Florian Tobias Schandinat > Cc: > Cc: Applied this patch. Thanks, Florian Tobias Schandinat > --- > drivers/video/omap/lcd_mipid.c | 1 - > drivers/video/omap2/displays/panel-acx565akm.c | 1 - > drivers/video/omap2/displays/panel-n8x0.c | 1 - > .../omap2/displays/panel-nec-nl8048hl11-01b.c | 1 - > .../video/omap2/displays/panel-tpo-td043mtea1.c | 1 - > 5 files changed, 0 insertions(+), 5 deletions(-) > > diff --git a/drivers/video/omap/lcd_mipid.c b/drivers/video/omap/lcd_mipid.c > index eb381db..8d546dd 100644 > --- a/drivers/video/omap/lcd_mipid.c > +++ b/drivers/video/omap/lcd_mipid.c > @@ -603,7 +603,6 @@ static int mipid_spi_remove(struct spi_device *spi) > static struct spi_driver mipid_spi_driver = { > .driver = { > .name = MIPID_MODULE_NAME, > - .bus = &spi_bus_type, > .owner = THIS_MODULE, > }, > .probe = mipid_spi_probe, > diff --git a/drivers/video/omap2/displays/panel-acx565akm.c b/drivers/video/omap2/displays/panel-acx565akm.c > index dbd59b8..51a87e1 100644 > --- a/drivers/video/omap2/displays/panel-acx565akm.c > +++ b/drivers/video/omap2/displays/panel-acx565akm.c > @@ -803,7 +803,6 @@ static int acx565akm_spi_remove(struct spi_device *spi) > static struct spi_driver acx565akm_spi_driver = { > .driver = { > .name = "acx565akm", > - .bus = &spi_bus_type, > .owner = THIS_MODULE, > }, > .probe = acx565akm_spi_probe, > diff --git a/drivers/video/omap2/displays/panel-n8x0.c b/drivers/video/omap2/displays/panel-n8x0.c > index 150e8ba..dc9408d 100644 > --- a/drivers/video/omap2/displays/panel-n8x0.c > +++ b/drivers/video/omap2/displays/panel-n8x0.c > @@ -708,7 +708,6 @@ static int mipid_spi_remove(struct spi_device *spi) > static struct spi_driver mipid_spi_driver = { > .driver = { > .name = "lcd_mipid", > - .bus = &spi_bus_type, > .owner = THIS_MODULE, > }, > .probe = mipid_spi_probe, > diff --git a/drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c b/drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c > index 2ba9d0c..8365e77 100644 > --- a/drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c > +++ b/drivers/video/omap2/displays/panel-nec-nl8048hl11-01b.c > @@ -303,7 +303,6 @@ static struct spi_driver nec_8048_spi_driver = { > .resume = nec_8048_spi_resume, > .driver = { > .name = "nec_8048_spi", > - .bus = &spi_bus_type, > .owner = THIS_MODULE, > }, > }; > diff --git a/drivers/video/omap2/displays/panel-tpo-td043mtea1.c b/drivers/video/omap2/displays/panel-tpo-td043mtea1.c > index 2462b9e..e6649aa 100644 > --- a/drivers/video/omap2/displays/panel-tpo-td043mtea1.c > +++ b/drivers/video/omap2/displays/panel-tpo-td043mtea1.c > @@ -512,7 +512,6 @@ static int __devexit tpo_td043_spi_remove(struct spi_device *spi) > static struct spi_driver tpo_td043_spi_driver = { > .driver = { > .name = "tpo_td043mtea1_panel_spi", > - .bus = &spi_bus_type, > .owner = THIS_MODULE, > }, > .probe = tpo_td043_spi_probe, ```