# Re: \[PATCH 0/15\] fbdev: sh\_mipi\_dsi: care un-explained register settings

- From: Magnus Damm \<magnus.damm@gmail.com\>
- Date: 2011-11-21 10:34:50 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2011/11/13462244
- Thread: https://ratatoskr.run/linux-fbdev/2011/11/13462242/t.md

```text
Hi Florian,

On Sat, Nov 12, 2011 at 12:37 AM, Florian Tobias Schandinat
[ref] wrote:
> Hi Guennadi, Magnus,
>
> On 11/09/2011 04:32 AM, kuninori.morimoto.gx@renesas.com wrote:
>> Dear Florian, Paul
>>
>> These are sh_mipi_dsi update patches.
>>
>> Kuninori Morimoto (15):
>>       fbdev: sh_mobile_lcdcfb: fixup LDHAJR :: HSYNPAJ needs mask
>>       fbdev: sh_mipi_dsi: tidyup dsip_clk
>>       fbdev: sh_mipi_dsi: typo fix of SH_MIPI_DSI_HBPBM
>>       fbdev: sh_mipi_dsi: tidyup VMCTR2 parameter expression
>>       fbdev: sh_mipi_dsi: add SH_MIPI_DSI_HFPBM flag
>>       fbdev: sh_mipi_dsi: add SH_MIPI_DSI_BL2E flag
>>       fbdev: sh_mipi_dsi: add lane control support
>>       fbdev: sh_mipi_dsi: add sync_pulses/sync_events/burst mode
>>       fbdev: sh_mipi_dsi: add VMLEN1/VMLEN2 calculation
>>       fbdev: sh_mipi_dsi: add set_dot_clock() for each platform
>>       fbdev: sh_mipi_dsi: add HSxxCLK support
>>       fbdev: sh_mipi_dsi: sh_mipi has pdata instead of dev
>>       fbdev: sh_mipi_dsi: fixup setup timing of sh_mipi_setup()
>>       fbdev: sh_mipi_dsi: fixup setup timing of SYSCONF
>>       fbdev: sh_mipi_dsi: fixup setup timing DSICTRL
>
> can you have a look at these patches?
> After a quick glance they look okay to me, but as this is all about hardware
> (which I don't know) I'd be happier if someone more qualified could have a look
> at it.

They all look fine to me. Please add:

Acked-by: Magnus Damm <redacted>

Thanks for your help,

/ magnus
```