# Re: \[PATCH 8/9\] drivers/video: fsl-diu-fb: merge diu\_hw into fsl\_diu\_data

- From: Timur Tabi \<hidden\>
- Date: 2011-10-03 15:58:43 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2011/10/13462099
- Thread: https://ratatoskr.run/linux-fbdev/2011/09/13461946/t.md

```text
Florian Tobias Schandinat wrote:
>> > +	struct diu __iomem *diu_reg;
>> > +	spinlock_t reg_lock;
>> > +	unsigned int mode;		/* DIU operation mode */

> Any reason that you added here a new "mode" var that appears to be useless when
> you just deleted the mode variable in patch 7/9?

Thanks for catching that.  That variable should not be there.  I will post a new
patch later today.

-- 
Timur Tabi
Linux kernel developer at Freescale

```