[PATCH 09/13] drivers/video: fsl-diu-fb: fix potential memcpy buffer overflow bug
From: Timur Tabi <hidden>
Date: 2011-09-15 21:44:54
Subsystem:
framebuffer layer, the rest · Maintainers:
Helge Deller, Linus Torvalds
It makes no sense to limit the size of a strncpy() to the length of the source string. Signed-off-by: Timur Tabi <redacted> --- drivers/video/fsl-diu-fb.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/video/fsl-diu-fb.c b/drivers/video/fsl-diu-fb.c
index 19bfbf5..3776949 100644
--- a/drivers/video/fsl-diu-fb.c
+++ b/drivers/video/fsl-diu-fb.c@@ -655,7 +655,7 @@ static void set_fix(struct fb_info *info) struct fb_var_screeninfo *var = &info->var; struct mfb_info *mfbi = info->par; - strncpy(fix->id, mfbi->id, strlen(mfbi->id)); + strncpy(fix->id, mfbi->id, sizeof(fix->id)); fix->line_length = var->xres_virtual * var->bits_per_pixel / 8; fix->type = FB_TYPE_PACKED_PIXELS; fix->accel = FB_ACCEL_NONE;
--
1.7.3.4