# Re: \[PATCH 0/3\] sh\_mobile\_lcdc cleanup and fixes

- From: Laurent Pinchart \<laurent.pinchart@ideasonboard.com\>
- Date: 2011-09-20 19:30:15 
- List: linux-fbdev
- Page: https://ratatoskr.run/linux-fbdev/2011/09/13461966
- Thread: https://ratatoskr.run/linux-fbdev/2011/07/13461712/t.md

```text
Hi Florian,

On Friday 15 July 2011 23:52:30 Laurent Pinchart wrote:
> Hi everybody,
> 
> When trying to understand the sh_mobile_lcdc driver, I found it hard to
> read statements that include hardcoded register values. I thus wrote a
> patch that replace them with macros, making the code more readable.
> 
> While doing so, I found two potential issues in the driver. See patches 2
> and 3 for detailed explanations and fixes.
> 
> Laurent Pinchart (3):
>   fbdev: sh_mobile_lcdc: Replace hardcoded register values with macros
>   fbdev: sh_mobile_lcdc: Don't acknowlege interrupts unintentionally
>   fbdev: sh_mobile_lcdc: Compute clock pattern using divider
>     denominator

Could you please pick these patches for v3.2 ?

-- 
Regards,

Laurent Pinchart
```